Page MenuHomePhabricator
Create Task
Maniphest T170609

Codemirror tries to show popup in NWE and fails spectacularly
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Codemirror throws console errors when attempting to show popup for new users in NWE. In one instance it did manage to show the popup and it was... not pretty to look at.

Details

SubjectRepoBranchLines +/-
Only show popup if CodeMirror button existsmediawiki/extensions/CodeMirrorwmf/1.30.0-wmf.12+5 -0
Only show popup if CodeMirror button existsmediawiki/extensions/CodeMirrormaster+5 -0
Customize query in gerrit

Event Timeline

• Niharika created this task.Jul 13 2017, 5:31 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 13 2017, 5:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Jul 14 2017, 9:49 AM
gerritbot subscribed.Aug 3 2017, 10:55 PM

Change 370111 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/CodeMirror@master] Only show popup if CodeMirror button exists

https://gerrit.wikimedia.org/r/370111

gerritbot added a project: Patch-For-Review.Aug 3 2017, 10:55 PM
gerritbot added a comment.Aug 3 2017, 11:03 PM

Change 370111 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Only show popup if CodeMirror button exists

https://gerrit.wikimedia.org/r/370111

gerritbot added a comment.Aug 3 2017, 11:03 PM

Change 370113 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/CodeMirror@wmf/1.30.0-wmf.12] Only show popup if CodeMirror button exists

https://gerrit.wikimedia.org/r/370113

gerritbot added a comment.Aug 3 2017, 11:09 PM

Change 370113 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@wmf/1.30.0-wmf.12] Only show popup if CodeMirror button exists

https://gerrit.wikimedia.org/r/370113

kaldari closed this task as Resolved.Aug 3 2017, 11:21 PM
kaldari claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 3 2017, 11:21 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Aug 4 2017, 12:00 AM
Jdforrester-WMF set the point value for this task to 0.Aug 9 2017, 2:49 PM
Jdforrester-WMF removed a project: Patch-For-Review.
kaldari moved this task from Needs Discussion to Archive on the Community-Tech board.Aug 17 2017, 12:46 AM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 9 2018, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL