[monobook-betalabs]: 'Live updates' missing the icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 14 2017, 11:52 PM

Description

In betalabs, RC page displays 'Live updates' button with the icon (Vector skin):

Screen Shot 2017-07-14 at 2.42.33 PM.png (197×684 px, 26 KB)

When the icon is clicked - the state of the icon clearly indicates its active state.

Switch to monobook skin and click on the 'Live updates'. The icon is missing and the active button state is not communicated clearly.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	icons: Add 'stop' icon to Apex theme	oojs/ui	v0.24.4	+6 -1
	icons: Add 'stop' icon to Apex theme	oojs/ui	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned In: T160918: Adjust the personal header to align with the design styleguide
T183195: Release OOUI v0.24.4 with some backported patches
Mentioned Here: T141801: WikimediaUI theme (Codex/OOUI) icon inventory (tracking)

Event Timeline

Etonkovidova created this task.Jul 14 2017, 11:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2017, 11:52 PM

Seems to be self-fixed - checked in Safari and Chrome: 'Live updates' button has the icon.

Etonkovidova closed this task as Resolved.Aug 8 2017, 5:53 PM

The ticket was re-opened - the description was updated to provide more details.

The main problem with monobook button in pressed state is missing "stop" icon. The reason is that OOjs UI icon pack doesn't have "stop" icon for monobook.

@Volker_E, I have noticed T141801 is tracking play icon as used, and stop does not have any usages listed. Both icons are used for "Live updates" button, but stop icon doesn't have Apex version, leading to issue described in this ticket.

Change 398191 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'stop' icon to Apex theme

https://gerrit.wikimedia.org/r/398191

gerritbot added a project: Patch-For-Review.Dec 14 2017, 1:12 AM

Thanks @Petar.petkovic for catching this!

Change 398191 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'stop' icon to Apex theme

https://gerrit.wikimedia.org/r/398191

This is going to be in v0.25.0 of OOUI.

In T170730#3836347, @Volker_E wrote:

Thanks @Petar.petkovic for catching this!

Thank you for adding the icon! It would be nice if OOjs UI icon inventory gets updated to include stop icon usages.

Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Dec 14 2017, 6:56 PM

@Petar.petkovic As this is a huge list maintained at T141801, and it's fairly hard to maintain overview on each and every products' icons for me, you're invited to keep it updated. :)

In T170730#3838409, @Volker_E wrote:

@Petar.petkovic As this is a huge list maintained at T141801, and it's fairly hard to maintain overview on each and every products' icons for me, you're invited to keep it updated. :)

I will gladly do it this time, since it indicates there are no usages for "stop" icon. Also, will try to keep updated every time I deem that it would be useful.

matmarex mentioned this in T183195: Release OOUI v0.24.4 with some backported patches.Dec 20 2017, 6:27 PM

Change 399448 had a related patch set uploaded (by Bartosz Dziewoński; owner: VolkerE):
[oojs/ui@v0.24.4] icons: Add 'stop' icon to Apex theme

https://gerrit.wikimedia.org/r/399448

gerritbot added a project: Patch-For-Review.Dec 20 2017, 6:47 PM

Change 399448 merged by jenkins-bot:
[oojs/ui@v0.24.4] icons: Add 'stop' icon to Apex theme