Page MenuHomePhabricator

mediawiki.skinning.content.externallinks isn't applying its styles to some skins
Closed, ResolvedPublic

Description

In order for skins to let the core mediawiki.skinning.content.externallinks ResourceLoader module apply it's styles correctly, skins need to switch to the mw-body-content class from the old mw-body class. (mw-body isn't deprecated anyways, so let's get this out of the way).

See https://gerrit.wikimedia.org/r/#/c/341073/ which caused this regression. Also see other (resolved) related bugs: T155863 + T159578

About to push out patches to the skins that are affected right now.

Event Timeline

Change 365462 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Bouquet@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365462

Change 365463 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/DeskMessMirrored@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365463

Change 365466 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Dusk@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365466

Change 365467 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/DuskToDawn@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365467

Change 365468 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Gamepress@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365468

Change 365469 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Nimbus@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365469

Change 365470 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Refreshed@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365470

Change 365462 merged by jenkins-bot:
[mediawiki/skins/Bouquet@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365462

Change 365463 merged by jenkins-bot:
[mediawiki/skins/DeskMessMirrored@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365463

Change 365466 merged by jenkins-bot:
[mediawiki/skins/Dusk@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365466

Change 365467 merged by jenkins-bot:
[mediawiki/skins/DuskToDawn@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365467

Change 365468 merged by jenkins-bot:
[mediawiki/skins/Gamepress@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365468

Change 365469 merged by jenkins-bot:
[mediawiki/skins/Nimbus@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365469

Change 365470 merged by jenkins-bot:
[mediawiki/skins/Refreshed@master] Switch mw-body class to mw-body-content class

https://gerrit.wikimedia.org/r/365470

Change 365519 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/WPtouch@master] Fix external link icons for MW 1.29 & clean up the code which adds the class to the <body> element

https://gerrit.wikimedia.org/r/365519

Change 365519 merged by jenkins-bot:
[mediawiki/skins/WPtouch@master] Fix external link icons for MW 1.29 & clean up the code which adds the class to the <body> element

https://gerrit.wikimedia.org/r/365519

SamanthaNguyen triaged this task as Medium priority.
SamanthaNguyen removed a project: Patch-For-Review.
SamanthaNguyen removed a subscriber: gerritbot.

So, I'm pretty sure this was finished a while ago. If there happens to be any other skins then feel free to re-open and poke me, but for now this will be mark as resolved.