Page MenuHomePhabricator

[BUG] Buttons on login screens have incorrect dimensions
Closed, ResolvedPublic1 Estimated Story Points

Description

EXPECTED

The buttons in the login/create account flows should be:

  • same width as the form fields (all should be 16dp from left and right hand side of screen)
  • standard button height of 36dp
ACTUAL

screenshot-2017-07-15-18-04-31-821385605.png (2×1 px, 95 KB)

Event Timeline

RHo renamed this task from Login button is too short? to [BUG] Buttons on login screens have incorrect dimensions .Jul 26 2017, 3:59 PM
RHo updated the task description. (Show Details)
RHo added a project: good first task.

Change 367920 had a related patch set uploaded (by Jcasariego; owner: Jcasariego):
[apps/android/wikipedia@master] Adjust button dimensions on login and create account screen

https://gerrit.wikimedia.org/r/367920

Change 367920 merged by jenkins-bot:
[apps/android/wikipedia@master] Adjust button dimensions on login and create account screen

https://gerrit.wikimedia.org/r/367920

RHo subscribed.

LGTM - Button width matches text field width on Login and Create account screens.

Nexus 5 login
main-MainActivity-08082017201547.png (1×1 px, 76 KB)
Nexus 5 create account
main-MainActivity-08082017201650.png (1×1 px, 99 KB)
Pixel login
Screenshot_20170808-202053.png (1×1 px, 63 KB)
Pixel create account
Screenshot_20170808-202102.png (1×1 px, 89 KB)

Tested on Pixel (Android 7.1.2) and Nexus 5 (Android 6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1

Looks good to me