EXPECTED
The buttons in the login/create account flows should be:
- same width as the form fields (all should be 16dp from left and right hand side of screen)
- standard button height of 36dp
• Niedzielski | |
Jul 15 2017, 11:08 PM |
F8988612: Screenshot_20170808-202102.png | |
Aug 8 2017, 6:25 PM |
F8988604: main-MainActivity-08082017201547.png | |
Aug 8 2017, 6:25 PM |
F8988614: Screenshot_20170808-202053.png | |
Aug 8 2017, 6:25 PM |
F8988607: main-MainActivity-08082017201650.png | |
Aug 8 2017, 6:25 PM |
F8773348: screenshot-2017-07-15-18-04-31-821385605.png | |
Jul 15 2017, 11:08 PM |
The buttons in the login/create account flows should be:
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Adjust button dimensions on login and create account screen | apps/android/wikipedia | master | +8 -4 |
Change 367920 had a related patch set uploaded (by Jcasariego; owner: Jcasariego):
[apps/android/wikipedia@master] Adjust button dimensions on login and create account screen
Change 367920 merged by jenkins-bot:
[apps/android/wikipedia@master] Adjust button dimensions on login and create account screen
LGTM - Button width matches text field width on Login and Create account screens.
Nexus 5 login | Nexus 5 create account | Pixel login | Pixel create account |
Tested on Pixel (Android 7.1.2) and Nexus 5 (Android 6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08