Maniphest T170758

Wikilabels uses deprecated api calls
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AnotherLadsgroup
	Jul 15 2017, 11:09 PM

Tags

Referenced Files

None

Subscribers

• AnotherLadsgroup

Description

When labeling on wikilabels, I get console.warning(), when checking calls this seems to happen. We need to fix this.

Event Timeline

• AnotherLadsgroup created this task.Jul 15 2017, 11:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2017, 11:09 PM

Found this: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2017-June/000134.html

TLDR is that this call should be something like this: https://nl.wikipedia.org/w/api.php?callback=jQuery213048846344104261585_1500159918758&action=compare&fromrev=44395668&torev=44395673&format=json&_=1500159918773

I made the fixes but it doesn't work the way expect :/ Let me spend some time on that.

Ladsgroup claimed this task.Jul 19 2017, 7:07 AM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 19 2017, 7:07 AM

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Jul 29 2017, 7:46 PM

https://github.com/wiki-ai/wikilabels/pull/197

Ladsgroup triaged this task as High priority.Aug 9 2017, 10:26 AM

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Aug 9 2017, 11:31 AM

Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Aug 14 2017, 10:30 AM

Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Aug 14 2017, 4:17 PM

Halfak closed this task as Resolved.Sep 22 2017, 9:17 PM