Per the QUnit docs, QUnit#test can handle promise resolution and rejection if the test function returns a thenable. Using assert#async when testing promises, therefore, is over-complicating the tests.
AC
- Any QUnit test that invokes assert#async and is dealing with promises:
- Shouldn't invoke assert#async.
- Should return a promise.
Notes
Files probably affected:
[0]
ag --js 'done\(\)' tests/node-qunit !2609 tests/node-qunit/actions.test.js 168: done(); 197: done(); 236: done(); 261: done(); 340: done(); 394: done(); 446: done(); tests/node-qunit/gateway/mediawiki.test.js 164: done(); 181: done(); 221: done(); tests/node-qunit/gateway/rest.test.js 238: done(); 251: done(); 264: done(); 297: done(); tests/node-qunit/integration.test.js 199: done(); 213: done(); 226: done(); 258: done(); tests/node-qunit/renderer.js 305: done(); 339: done(); 373: done(); tests/node-qunit/wait.test.js 22: done();
There are a maximum of 22 tests affected.