Page MenuHomePhabricator
Create Task
Maniphest T170861

[Bug 🐛 ] Share links for articles including punctuation
Closed, ResolvedPublic
Actions

Description

Steps to reproduce
Search for the article "Hand. Cannot. Erase." (https://en.wikipedia.org/wiki/Hand._Cannot._Erase.)
Tap on the share button
Select 'Share to Twitter'
Share Tweet

Expected result
Tweet includes a truncated but working URL

Actual result

IMG_3453.PNG (1×750 px, 107 KB)

Link is broken and URL is different from web address:

Link above goes to: https://en.wikipedia.org/wiki/Hand._Cannot._Erase
Whereas the article URL is:https://en.wikipedia.org/wiki/Hand._Cannot._Erase. (note the last period)

NOTE: I tried this out with a few other articles that include punctuation (Eats, Shoots and Leaves + Papier-mâché) but could not find another article where this happens.

Related Objects
Search...

Event Timeline

cmadeo created this task.Jul 17 2017, 6:29 PM
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptJul 17 2017, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• JMinor renamed this task from [Bug 🐛 ] Share links for articles including to [Bug 🐛 ] Share links for articles including punctuation.Jul 17 2017, 6:39 PM
• JMinor triaged this task as Low priority.
• JMinor added a project: iOS-app-v5.6.0-Goat-On-A-Train.
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.6.0-Goat-On-A-Train board.
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• NHarateh_WMF added subscribers: JoeWalsh, • NHarateh_WMF.Jul 17 2017, 11:05 PM

Could this be related to Sharing article title with an exclamation mark does not encode it for urls? @JoeWalsh

Seems like the lack of the last dot in the link posted to Twitter makes it invalid (see the last tweet at https://twitter.com/testwikipedia). It works in Safari (and other sharing options).

cmadeo added a comment.Jul 17 2017, 11:10 PM

Link above goes to: https://en.wikipedia.org/wiki/Hand._Cannot._Erase
Whereas the article URL is: https://en.wikipedia.org/wiki/Hand._Cannot._Erase. (note the last period)

Weirdly it's even causing issues on Phab too :(

• JMinor edited projects, added iOS-app-v5.6.1-Goat-On-A-Plane; removed iOS-app-v5.6.0-Goat-On-A-Train.Jul 18 2017, 9:36 PM
• JMinor subscribed.

This turned out to be more complex than expected, both on the UX side and on the URL encoding side, so I'm pushing this to a future release, along with other sharing improvements.

• JMinor added a parent task: T172203: As a user who wants to share a fact or article, I want it to be easy and intuitive to do.Aug 1 2017, 6:35 PM
• JMinor edited projects, added iOS-app-v5.7.0-Corgi-On-A-Surfboard; removed iOS-app-v5.6.1-Goat-On-A-Plane.
• JMinor moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 8 2017, 6:34 PM
cmadeo updated the task description. (Show Details)Aug 29 2017, 6:51 PM
cmadeo updated the task description. (Show Details)
cmadeo updated the task description. (Show Details)
Mhurd subscribed.EditedAug 29 2017, 6:53 PM

Reminder: Test any fixes with a non-latin character set lang article which has a period. Arabic, Russian etc.

cmadeo moved this task from Needs Design to Needs Acceptance Criteria on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 29 2017, 6:53 PM
JoeWalsh claimed this task.Aug 29 2017, 7:13 PM
JoeWalsh edited projects, added iOS-app-v5.6.1-Goat-On-A-Plane; removed iOS-app-v5.7.0-Corgi-On-A-Surfboard.
JoeWalsh moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.
JoeWalsh added a comment.Aug 29 2017, 7:21 PM

Simulator Screen Shot Aug 29, 2017, 3.20.45 PM.png (1×750 px, 166 KB)

tested these articles in Arabic - tested open in Safari as well as verifying that save and history worked as expected

• NHarateh_WMF moved this task from Needs Code Review to Needs QA on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 31 2017, 1:33 PM
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.6.1-Goat-On-A-Plane board.Sep 5 2017, 11:58 PM
ABorbaWMF subscribed.

Tested on iPhone 7+ with iOS 10.3.3on App 5.6.1 (1212)

Working

• JMinor closed this task as Resolved.Sep 26 2017, 3:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL