Page MenuHomePhabricator
Create Task
Maniphest T170872

Align VisualEditor-MediaWiki's naming of setup/teardown methods to QUnit 2.x
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: Align setup/teardown function naming with QUnit 2.xmediawiki/extensions/Citemaster+2 -2
tests: Remove legacy setup/teardown function naming from QUnit 1.xmediawiki/extensions/VisualEditormaster+0 -4
tests: Align setup/teardown function naming with QUnit 2.xmediawiki/extensions/VisualEditormaster+15 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jul 17 2017, 7:07 PM
gerritbot added a comment.Jul 17 2017, 7:10 PM

Change 365682 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] tests: Make VisualEditor-MediaWiki compatible with QUnit 2

https://gerrit.wikimedia.org/r/365682

gerritbot added a project: Patch-For-Review.Jul 17 2017, 7:10 PM
• Deskana triaged this task as Medium priority.Jul 18 2017, 7:08 PM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF renamed this task from Make VisualEditor-MediaWiki compatible with QUnit 2 to Align VisualEditor-MediaWiki's naming of setup/teardown methods to QUnit 2.x.Jul 20 2017, 9:14 PM
Jdforrester-WMF lowered the priority of this task from Medium to Lowest.
Jdforrester-WMF edited parent tasks, added: T171221: Drop setup/teardown backwards compatibility calls for beforeEach/afterEach in QUnit.newMwEnvironment; removed: T170515: Upgrade MediaWiki core to QUnit 2.
• Deskana moved this task from TR0: Interrupt to TR1: Releases on the VisualEditor board.Aug 24 2017, 10:35 AM
• Deskana moved this task from TR1: Releases to Freezer on the VisualEditor board.Aug 16 2018, 4:45 PM
Aklapper edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Oct 15 2020, 1:27 PM
gerritbot added a comment.Feb 5 2021, 6:58 PM

Change 661980 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] tests: Align setup/teardown function naming with QUnit 2.x

https://gerrit.wikimedia.org/r/661980

gerritbot added a project: Patch-For-Review.Feb 5 2021, 6:58 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptFeb 5 2021, 6:58 PM
gerritbot added a comment.Feb 5 2021, 7:35 PM

Change 661986 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] tests: Remove legacy setup/teardown function naming from QUnit 1.x

https://gerrit.wikimedia.org/r/661986

gerritbot added a comment.Feb 8 2021, 7:24 PM

Change 365682 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] tests: Align setup/teardown function naming with QUnit 2.x

https://gerrit.wikimedia.org/r/365682

gerritbot added a comment.Feb 8 2021, 7:36 PM

Change 661980 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] tests: Align setup/teardown function naming with QUnit 2.x

https://gerrit.wikimedia.org/r/661980

gerritbot added a comment.Feb 8 2021, 7:36 PM

Change 661986 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] tests: Remove legacy setup/teardown function naming from QUnit 1.x

https://gerrit.wikimedia.org/r/661986

Jdforrester-WMF closed this task as Resolved.Feb 8 2021, 7:36 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 8 2021, 7:36 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 8 2021, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits