| JoeWalsh | |
| Jul 17 2017, 7:29 PM |
| F8789639: Simulator Screen Shot Jul 17, 2017, 3.08.31 PM.png | |
| Jul 17 2017, 7:29 PM |
| F8789637: Simulator Screen Shot Jul 17, 2017, 3.09.47 PM.png | |
| Jul 17 2017, 7:29 PM |
| F8789641: Screen Shot 2017-07-17 at 12.18.08 PM.png | |
| Jul 17 2017, 7:29 PM |
| F8789644: Simulator Screen Shot Jul 17, 2017, 3.21.28 PM.png | |
| Jul 17 2017, 7:29 PM |
Currently the app uses a custom popover background arrow (pointed). With the new reading themes, this would require a custom class for each theme since UIPopoverPresentationController takes a custom class and doesn't allow access to changing a given instance's properties (like the background color).
I'm proposing that we utilize the built-in popover background arrow (rounded) which can have any background color applied.
Before:
After:
Yeah, the custom one's a little "cleaner" looking to my eye, but I don't think it matters enough to justify custom development.
However, this is a purely visual issue, so ultimately @cmadeo call.