Page MenuHomePhabricator

Make MobileFrontend compatible with QUnit 2
Closed, ResolvedPublic

Description

At least one use of QUnit.asyncTest found in MobileFrontend (deprecated since QUnit 1.16, removed in QUnit 2). Core currently uses QUnit 1.23.

$ git grep asyncTest
tests/qunit/mobile.search.api/test_SearchGateway.js:    QUnit.asyncTest( 'Wikidata Description in search results', 3, function ( assert ) {

Migrate to either returning a Promise to QUnit.test(), or use assert.async().

https://api.qunitjs.com/QUnit/test
https://api.qunitjs.com/assert/async

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterAvoid use of deprecated QUnit.asyncTest()

Event Timeline

Krinkle created this task.Jul 17 2017, 8:38 PM

Change 367820 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/MobileFrontend@master] Avoid use of deprecated QUnit.asyncTest()

https://gerrit.wikimedia.org/r/367820

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 25 2017, 11:04 PM
Krinkle claimed this task.Jul 25 2017, 11:12 PM

Change 367820 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid use of deprecated QUnit.asyncTest()

https://gerrit.wikimedia.org/r/367820

Krinkle closed this task as Resolved.Jul 25 2017, 11:28 PM
Krinkle removed a project: Patch-For-Review.