Page MenuHomePhabricator

Notification overlay in mobile has a mysterious indent for heading
Closed, ResolvedPublic

Description

Notice how at tablet and desktop resolutions the heading for notifications is indented:

Screen Shot 2017-07-17 at 4.36.00 PM.png (708×967 px, 118 KB)

Styles applying a max-width to overlays seem to be causing problems here. The notifications overlay is a special case in that it appears as a drawer in tablet mode.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 384621 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove indent from the notification overlay header

https://gerrit.wikimedia.org/r/384621

This was an easy fix so I posted a patch. I'd appreciate some review from the Collaboration team here. My team was also tracking it as something the collaboration team would fix, hence why it got ignored (I see it was put in "External" column which I assume means "another team will fix it" ?).

Change 384621 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove indent from the notification overlay header

https://gerrit.wikimedia.org/r/384621

Jdlrobson claimed this task.

Indent is now gone

Screen Shot 2017-10-20 at 10.52.41 AM.png (443×718 px, 23 KB)