⚓ T170917 Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}"

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Thanks	wmf/1.30.0-wmf.10	+1 -0	Add missing jQueryMsg dependency for mobile diff view
mediawiki/extensions/Thanks	master	+1 -0	Add missing jQueryMsg dependency for mobile diff view
mediawiki/extensions/Thanks	wmf/1.30.0-wmf.9	+1 -0	Add missing jQueryMsg dependency for mobile diff view

ovasileva created this task.Jul 18 2017, 11:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2017, 11:22 AM

ovasileva triaged this task as High priority.Jul 18 2017, 11:22 AM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Jul 18 2017, 11:47 AM

Aklapper renamed this task from Thank button broken on mobilefrontend to Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}".Jul 18 2017, 12:02 PM

Aklapper added projects: MobileFrontend, Thanks.

Aklapper updated the task description. (Show Details)

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 18 2017, 12:02 PM

Liuxinyu970226 added a parent task: T32443: [DO NOT USE] GENDER (tracking) [superseded by #Gender-Support].Jul 18 2017, 12:24 PM

ovasileva moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.Jul 18 2017, 12:56 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.

ovasileva moved this task from Upcoming to 2017-18 Q1 on the Readers-Web-Backlog board.

regression we should fix - moving this into the sprint

It might be related to caching issue, as if I visit this page with debug=true I don't see the error (https://en.m.wikipedia.org/wiki/Special:MobileDiff/791098920?debug=true vs https://en.m.wikipedia.org/wiki/Special:MobileDiff/791098920)

I tried this a bunch of times using the article listed above. Twice, out of the approximately 40 times, I viewed an edit where the thanks button was wonky. I'm not sure how I triggered it, but it was after a lot of tapping on past edits.

• Mattflaschen-WMF claimed this task.Jul 18 2017, 7:21 PM

Change 366028 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Thanks@master] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366028

gerritbot added a project: Patch-For-Review.Jul 18 2017, 7:26 PM

The above should fix it (it works locally).

There was a missing dependency, which means it's unpredictable (depending on what other extensions and features are on the page, and other factors) whether the module will work correctly.

In T170917#3448801, @pmiazga wrote:

It might be related to caching issue, as if I visit this page with debug=true I don't see the error (https://en.m.wikipedia.org/wiki/Special:MobileDiff/791098920?debug=true vs https://en.m.wikipedia.org/wiki/Special:MobileDiff/791098920)

In this case, something else is probably coincidentally loading mediawiki.jQueryMsg, but not early enough. It's common for the load order to be different in debug mode, hiding these issues.

• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 18 2017, 8:41 PM

Change 366028 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366028

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 18 2017, 10:00 PM

Change 366168 had a related patch set uploaded (by Jdlrobson; owner: Mattflaschen):
[mediawiki/extensions/Thanks@wmf/1.30.0-wmf.9] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366168

gerritbot added a project: Patch-For-Review.Jul 18 2017, 11:02 PM

It's fixed on MediaWiki.org (https://m.mediawiki.org/wiki/Special:MobileDiff/2509350). I've added this to the swat calendar to fix wmf9.

Change 366168 merged by jenkins-bot:
[mediawiki/extensions/Thanks@wmf/1.30.0-wmf.9] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366168

Mentioned in SAL (#wikimedia-operations) [2017-07-18T23:27:28Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.9/extensions/Thanks/extension.json: SWAT: [[gerrit:366168|Add missing jQueryMsg dependency for mobile diff view]] T170917 (duration: 00m 47s)

Verified fixed on wmf9. Thanks @Mattflaschen-WMF for getting this fixed :)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 19 2017, 12:00 AM

LGTM! I tested this on en.m. and it looks as if @Jdlrobson has too (T170917#3450738).

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jul 19 2017, 8:11 AM

cc @MaxSem apparently this fix didn't make it into wmf10....

e.g. https://en.m.wikipedia.org/wiki/Special:MobileDiff/791540642

Catrope merged a task: T171317: Thanks button doesn't appear well on mobile .Jul 21 2017, 7:42 PM

Catrope added subscribers: Bencemac, IKhitron, Amire80, Srdjan.

Change 366899 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Thanks@wmf/1.30.0-wmf.10] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366899

Vachovec1 added a subscriber: Vachovec1.Jul 22 2017, 8:18 AM

Sjoerddebruin merged a task: T171431: Thank button in mobile view sometimes with unresolved GENDER.Jul 24 2017, 7:28 AM

Sjoerddebruin added a subscriber: Schnark.

Trizek-WMF added a subscriber: Trizek-WMF.Jul 24 2017, 8:54 AM

Jdlrobson merged a task: T171388: Garbled text in mobile thank button.Jul 24 2017, 3:25 PM

Jdlrobson added a subscriber: Nirmos.

looked at this quickly today and the thank button seems to be missing

@ovasileva button is there and the issue still exists on production servers.

See https://phabricator.wikimedia.org/T170917#3461506 onwards. It's scheduled for SWAT at 11am.

Change 366899 merged by jenkins-bot:
[mediawiki/extensions/Thanks@wmf/1.30.0-wmf.10] Add missing jQueryMsg dependency for mobile diff view

https://gerrit.wikimedia.org/r/366899

Mentioned in SAL (#wikimedia-operations) [2017-07-24T18:13:40Z] <reedy@tin> Synchronized php-1.30.0-wmf.10/extensions/Thanks/extension.json: T170917 (duration: 00m 43s)

Catrope closed this task as Resolved.Jul 24 2017, 6:29 PM

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 24 2017, 7:00 PM

Jdlrobson merged a task: T171064: Gender unknown Thank bug on mobile.Jul 25 2017, 5:35 PM

Jdlrobson added a subscriber: Wittylama.

Trizek-WMF added projects: User-notice, User-notice-collaboration.Jul 31 2017, 9:25 AM

Trizek-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jul 31 2017, 9:34 AM

Trizek-WMF moved this task from To Triage to Announce in next Collaboration Newsletter on the User-notice-collaboration board.

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Aug 3 2017, 5:05 AM

RandomDSdevel awarded a token.Aug 8 2017, 12:45 AM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 9 2017, 2:45 PM

Trizek-WMF removed a project: User-notice-collaboration.Oct 13 2017, 4:35 PM

MarcoAurelio added a project: Gender-Support.Nov 15 2017, 8:07 PM