Wikistats2 bugs (4/4) - Detail page
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	mforns
	Jul 18 2017, 2:34 PM

Description

The date range selector does not show selected option when not focused.

If we select 1 year in the time-range selector, the graph shows 13 data points. Is that expected?

If we enable the breakdown, the graph shows one sub-column for each breakdown value, but the last data-point has only 1 sub-column.

The scale repeats points 10G, 10G, 10G, 20G, 20G

And BTW, I understand G is an abbreviation for Billion, like in 128 GB. But outside the IT context, shouldn't it be 20B instead of 20G?

Full-screen mode does not have a border on the left hand side, is that expected?

Tasked T173372 [x] - When we select 1 month time-range, the graph shows 1 data point only. Is that expected? With 3 months there are 3 data points. Should we revisit the auto-granularity?

When selecting a single month as time-range the total indicated below does not match the value in the chart. This might happen in other time-ranges, but in this case it's easy to spot.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use B instead of G to represent billion in the detail page	analytics/wikistats2	master	+17 -3

Customize query in gerrit

Revisions and Commits

rWIKISTATS analytics-wikistats-new
	Restricted Differential Revision	rWIKISTATSc48178e35b7f Prevent timerange selection to become inactive
		rWIKISTATSb7ef2649163e Squashed commit of the following:
		rWIKISTATS7e056414a481 Squashed commit of the following:
	Restricted Differential Revision	rWIKISTATSc6d2aac695a1 Activate 2-year button as default in Time Range
		rWIKISTATSdcd60c0825c7 Squashed commit of the following:
	Restricted Differential Revision	rWIKISTATS3a93ca97fced Fix visibility of last breakdown bars
	Restricted Differential Revision	rWIKISTATS43d5f9fa0014 Correct precision gaps in y axis rounding

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T120037 Vital Signs: Please provide an "all languages" de-duplicated stream for the Community/Content groups of metrics
Resolved	None	T120036 Vital Signs: Please make the data for enwiki and other big wikis less sad, and not just be missing for most days
Resolved	• odimitrijevic	T130256 Wikistats 2.0.
Resolved	None	T170460 Wikistats 2.0 UI second deployment/iteration
Resolved	• fdans	T170940 Wikistats2 bugs (4/4) - Detail page

Event Timeline

mforns created this task.Jul 18 2017, 2:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2017, 2:34 PM

mforns added a parent task: T170460: Wikistats 2.0 UI second deployment/iteration.Jul 18 2017, 2:37 PM

Liuxinyu970226 subscribed.Jul 18 2017, 2:39 PM

• fdans set the point value for this task to 5.Jul 24 2017, 4:11 PM

• fdans edited projects, added Analytics-Kanban; removed Analytics.

• fdans updated the task description. (Show Details)Jul 24 2017, 4:18 PM

• fdans moved this task from Next Up to In Progress on the Analytics-Kanban board.Aug 7 2017, 4:18 PM

• fdans updated the task description. (Show Details)Aug 8 2017, 6:36 PM

• fdans claimed this task.Aug 15 2017, 12:48 PM

• fdans added a revision: Restricted Differential Revision.Aug 15 2017, 1:36 PM

• fdans updated the task description. (Show Details)

• fdans added a revision: Restricted Differential Revision.Aug 15 2017, 2:01 PM

• fdans updated the task description. (Show Details)Aug 15 2017, 2:02 PM

• fdans added a revision: Restricted Differential Revision.Aug 15 2017, 2:16 PM

• fdans updated the task description. (Show Details)Aug 15 2017, 2:16 PM

• fdans mentioned this in T173372: Use daily granularity for 1-month time ranges .Aug 15 2017, 2:27 PM

• fdans updated the task description. (Show Details)

The last point is fixed by D753

• fdans moved this task from In Progress to Ready to Deploy on the Analytics-Kanban board.Aug 15 2017, 2:29 PM

• fdans moved this task from Ready to Deploy to In Code Review on the Analytics-Kanban board.

• fdans added a commit: rWIKISTATS43d5f9fa0014: Correct precision gaps in y axis rounding.Aug 29 2017, 10:55 PM

• fdans added a commit: rWIKISTATS3a93ca97fced: Fix visibility of last breakdown bars.Aug 29 2017, 11:01 PM

• fdans added a commit: rWIKISTATSdcd60c0825c7: Squashed commit of the following:.Aug 29 2017, 11:08 PM

• fdans added a commit: rWIKISTATSc6d2aac695a1: Activate 2-year button as default in Time Range.Sep 4 2017, 12:06 PM

• fdans moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Sep 4 2017, 12:16 PM

• fdans added a commit: rWIKISTATS7e056414a481: Squashed commit of the following:.Sep 6 2017, 2:30 PM

• Nuria moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Sep 6 2017, 3:01 PM

Still a few problems:

The date range selector does not show selected option when not focused. (try clicking 1 year and then clicking on the graph selector dropdown)
If we select 1 year in the time-range selector, the graph shows 13 data points. Is that expected? (now it's showing 11, I would think 13 is good, so you can get YoY comparison.
I understand G is an abbreviation for Billion, like in 128 GB. But outside the IT context, shouldn't it be 20B instead of 20G? (I agree with that - easily changed in the filters setup in main.js)
Full-screen mode does not have a border on the left hand side, is that expected? (border's a bit thicker than the right side now, if this is painful CSS I can take a look or we can just skip)

Milimetric moved this task from Done to In Code Review on the Analytics-Kanban board.Sep 13 2017, 4:55 PM

If we select 1 year in the time-range selector, the graph shows 13 data points. Is that expected? (now it's showing 11, I would think 13 is good, so you can get YoY comparison.

11 months is the result of asking the api data for the last 12 months. @mforns and I agreed to not get into the implementation details of the api when setting the date ranges

Full-screen mode does not have a border on the left hand side, is that expected? (border's a bit thicker than the right side now, if this is painful CSS I can take a look or we can just skip)

This should be part of a broader task to make the application responsive.

• fdans added a revision: Restricted Differential Revision.Sep 13 2017, 6:00 PM

• fdans moved this task from In Code Review to In Progress on the Analytics-Kanban board.Sep 15 2017, 2:25 PM

• fdans added a commit: rWIKISTATSb7ef2649163e: Squashed commit of the following:.Sep 19 2017, 2:57 PM

In T170940#3605104, @fdans wrote:

If we select 1 year in the time-range selector, the graph shows 13 data points. Is that expected? (now it's showing 11, I would think 13 is good, so you can get YoY comparison.

11 months is the result of asking the api data for the last 12 months. @mforns and I agreed to not get into the implementation details of the api when setting the date ranges

Full-screen mode does not have a border on the left hand side, is that expected? (border's a bit thicker than the right side now, if this is painful CSS I can take a look or we can just skip)

This should be part of a broader task to make the application responsive.

Agreed these two are not issues right now then.

• fdans added a commit: rWIKISTATSc48178e35b7f: Prevent timerange selection to become inactive.Oct 2 2017, 2:56 PM

Change 383071 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Use B instead of G to represent billion in the detail page

https://gerrit.wikimedia.org/r/383071

gerritbot added a project: Patch-For-Review.Oct 9 2017, 7:35 AM

• fdans moved this task from In Progress to In Code Review on the Analytics-Kanban board.Oct 9 2017, 11:39 AM

Change 383071 merged by Mforns:
[analytics/wikistats2@master] Use B instead of G to represent billion in the detail page

https://gerrit.wikimedia.org/r/383071

• fdans moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Oct 9 2017, 2:55 PM

• fdans moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Oct 18 2017, 10:26 AM

• Nuria closed this task as Resolved.Oct 24 2017, 11:48 PM

Liuxinyu970226 unsubscribed.Oct 25 2017, 4:33 AM