Page MenuHomePhabricator

qunit tests for wikilabels
Closed, DeclinedPublic

Description

This task is done when:
1- There are basic qunit tests for wikilabels
2- They pass
3- They are integrated with travis

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedHalfak
DeclinedNone

Event Timeline

Halfak raised the priority of this task from Low to Medium.
Halfak moved this task from Unsorted to Maintenance/cleanup on the Machine-Learning-Team board.
Aklapper added a subscriber: awight.

@awight, @Ladsgroup: Please provide information / links how to create "qunit tests for wikilabels" and how to "integrate with travis".
https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing ? What does a contributor need to already know? What does "basic" mean when it comes to declaring this task "resolved"? A contributor is expected to provide a pull request to https://github.com/wiki-ai/wikilabels ?

@awight: Please see the criteria defined at https://phabricator.wikimedia.org/tag/easy/ - this task is not good first task yet.

@Aklapper That guideline is for writing qunit tests in mediawiki which is indeed not easy. In wikilabels, you have control to install npm and do whatever magic you want to do to make it happen, and I don't want 100% coverage, one or two basic test is enough (just to be sure we have the whole pipeline there so I can write more tests on top of that)

@Ladsgroup: Thanks, however if I've never seen Wikilabels and don't know which "npm" you refer to (or what that is), and how to "integrate with travis", I'd still need more information as a complete newcomer to this task. Editing the task description via Edit Task is welcome, to describe what skills I'd need to have to work on this, which steps I'm supposed to perform, and what's expected from me (what's a "basic test"?) to call this task "resolved" from my side. Thanks a lot! :)

@Ladsgroup: Any chance / time to reply to my previous comment so we could maybe turn this into GCI tasks (how much to do per 1 task)? Thanks in advance!

@ACraze: What is the reason to be against adding unit tests to Wikilabels, by declining this ticket? This doesn't make much sense to me.

@Aklapper we already have solid unit and integration tests in place for Wikilabels. This ticket is proposing adding an additional testing framework (which has a large number of dependencies) for UI testing only, which I just don't see the value in right now. Additionally, we have plans to deprecate Wikilabels in the near future over concerns with the UI. Both of these reasons are why the ticket was declined.