Page MenuHomePhabricator

Add missing theme colors to certain article elements
Closed, ResolvedPublic

Description

Sepia:

  • Collapsed tables
  • Footer

Dark:

  • Footer

Event Timeline

JMinor triaged this task as Medium priority.Jul 24 2017, 7:28 PM
JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JMinor moved this task from Bug Backlog to Product Backlog on the Wikipedia-iOS-App-Backlog board.

Testing criteria

  • load an article which has a collapsed table such as Barack Obama

Tables

  • scroll to the table and tap it to open it
  • tap the theme icon in the toolbar at the bottom of the article
  • select the dark theme and ensure the table changes changes to use dark colors
  • select the sepia theme and ensure the table changes changes to use sepia colors

About this article

  • now scroll to bottom of the article to the "About this article" section (you can use the Table of contents icon in the toolbar if you like)
  • tap the theme icon in the toolbar at the bottom of the article
  • select the dark theme and ensure the "About this article" menu changes to use dark colors
  • select the sepia theme and ensure the "About this article" menu changes to use sepia colors

Read more

  • now scroll to bottom of the article to the "Read more" section (you can use the Table of contents icon in the toolbar if you like)
  • tap the theme icon in the toolbar at the bottom of the article
  • select the dark theme and ensure the "Read more" items change to use dark colors
  • select the sepia theme and ensure the "Read more" items change to use sepia colors

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1187). This is fixed according to the screencaps below.

T171095 Table Dark.PNG (1×750 px, 578 KB)
T171095 Table Sepia.PNG (1×750 px, 578 KB)
T171095 About this article and Read More Dark.PNG (1×750 px, 259 KB)
T171095 About this article and Read More Sepia.PNG (1×750 px, 258 KB)

ABorbaWMF subscribed.

Tested on iPad Pro with iOS 10.3.3 and iPhone 7+ with iOS 10.3.3 on App 5.6.0 (1190)

Fixed