Page MenuHomePhabricator
Create Task
Maniphest T171107

Class undefined: \Wikibase\Lib\JsonUnitStorage
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production immediately upon rolling out wmf.10:

Fatal error: Class undefined: \Wikibase\Lib\JsonUnitStorage in /srv/mediawiki/php-1.30.0-wmf.10/includes/libs/ObjectFactory.php on line 143

Definitely blocks train.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+4 -16Remove obsolete backwards compatibility code for "unitStorage" config
mediawiki/extensions/Wikibasemaster+23 -9Allow "unitStorage" configuration without referencing class names
operations/mediawiki-configmaster+1 -9Simplify Wikibase "unitStorage" configuration
operations/mediawiki-configmaster+1 -6Cleanup old BC config for JsonUnitStorage
operations/mediawiki-configmaster+1 -1wikidatawiki back to wmf.10
operations/mediawiki-configmaster+6 -1Use correct class name for JsonUnitStorage
operations/mediawiki-configmaster+1 -1wikidatawiki back to wmf.9 for now
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedemonT168050 MW 1.30.0-wmf.10 deployment blockers
 ResolvedPRODUCTION ERRORSmalyshevT171107 Class undefined: \Wikibase\Lib\JsonUnitStorage

Event Timeline

demon created this task.Jul 19 2017, 9:04 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes, Aklapper. · View Herald TranscriptJul 19 2017, 9:04 PM
demon added a parent task: T168050: MW 1.30.0-wmf.10 deployment blockers.Jul 19 2017, 9:04 PM
demon merged a task: T171097: Class undefined: \Wikibase\Lib\JsonUnitStorage.
gerritbot added a subscriber: gerritbot.Jul 19 2017, 9:28 PM

Change 366467 had a related patch set uploaded (by Chad; owner: Chad):
[operations/mediawiki-config@master] wikidatawiki back to wmf.9 for now

https://gerrit.wikimedia.org/r/366467

gerritbot added a project: Patch-For-Review.Jul 19 2017, 9:28 PM
gerritbot added a comment.Jul 19 2017, 9:51 PM

Change 366467 merged by jenkins-bot:
[operations/mediawiki-config@master] wikidatawiki back to wmf.9 for now

https://gerrit.wikimedia.org/r/366467

Smalyshev added a subscriber: Smalyshev.Jul 19 2017, 10:41 PM
Smalyshev added a comment.Jul 19 2017, 10:44 PM

Hmm should be Wikibase\Lib\Units\JsonUnitStorage. Looks like config should be fixed?

gerritbot added a comment.Jul 19 2017, 10:45 PM

Change 366480 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[operations/mediawiki-config@master] Use correct class name for JsonUnitStorage

https://gerrit.wikimedia.org/r/366480

Smalyshev added a comment.EditedJul 19 2017, 10:51 PM

wmf.9 had this class name as Wikibase\Lib\JsonUnitStorage, in wmf.10 it's Wikibase\Lib\Units\JsonUnitStorage. Not sure what is the recommended way to handle such things? Should it use ::class?

Smalyshev added a subscriber: thiemowmde.Jul 19 2017, 10:55 PM
gerritbot added a comment.Jul 19 2017, 11:21 PM

Change 366480 merged by jenkins-bot:
[operations/mediawiki-config@master] Use correct class name for JsonUnitStorage

https://gerrit.wikimedia.org/r/366480

Stashbot added a subscriber: Stashbot.Jul 19 2017, 11:29 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-19T23:29:02Z] <dereckson@tin> Synchronized wmf-config/Wikibase-production.php: Use correct class name for JsonUnitStorage (T171107) (duration: 00m 48s)

Smalyshev closed this task as Resolved.Jul 19 2017, 11:32 PM
Smalyshev claimed this task.
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jul 19 2017, 11:36 PM
Smalyshev added subscribers: daniel, aude.Jul 19 2017, 11:42 PM
gerritbot added a comment.Jul 19 2017, 11:44 PM

Change 366488 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[operations/mediawiki-config@master] Cleanup old BC config for JsonUnitStorage

https://gerrit.wikimedia.org/r/366488

gerritbot added a comment.Jul 20 2017, 10:40 AM

Change 366532 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Allow "unitStorage" configuration without referencing class names

https://gerrit.wikimedia.org/r/366532

gerritbot added a comment.Jul 20 2017, 10:43 AM

Change 366533 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[operations/mediawiki-config@master] Simplify Wikibase "unitStorage" configuration

https://gerrit.wikimedia.org/r/366533

gerritbot added a comment.Jul 20 2017, 10:46 AM

Change 366534 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove obsolete backwards compatibility code for "unitStorage" config

https://gerrit.wikimedia.org/r/366534

demon added a comment.Jul 20 2017, 4:01 PM

Thanks for all the work on this yesterday folks. We're resolved, so I'm guessing ok to move forward on wmf.10 for wikidatawiki?

Smalyshev added a comment.Jul 20 2017, 4:41 PM

@demon Yes, I believe it is fine now. I'll keep an eye on the logs just in case.

gerritbot added a comment.Jul 20 2017, 4:50 PM

Change 366589 had a related patch set uploaded (by Chad; owner: Chad):
[operations/mediawiki-config@master] wikidatawiki back to wmf.10

https://gerrit.wikimedia.org/r/366589

gerritbot added a comment.Jul 20 2017, 5:14 PM

Change 366589 merged by jenkins-bot:
[operations/mediawiki-config@master] wikidatawiki back to wmf.10

https://gerrit.wikimedia.org/r/366589

gerritbot added a comment.Jul 31 2017, 11:05 PM

Change 366488 merged by jenkins-bot:
[operations/mediawiki-config@master] Cleanup old BC config for JsonUnitStorage

https://gerrit.wikimedia.org/r/366488

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 31 2017, 11:05 PM
Stashbot added a comment.Jul 31 2017, 11:11 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-31T23:11:10Z] <thcipriani@tin> Synchronized wmf-config/Wikibase-production.php: SWAT: [[gerrit:366488|Cleanup old BC config for JsonUnitStorage]] T171107 (duration: 00m 42s)

gerritbot added a comment.Sep 14 2017, 8:14 AM

Change 366533 abandoned by Thiemo Mättig (WMDE):
Simplify Wikibase "unitStorage" configuration

Reason:
I need to redo the patch this depends-on, and will upload a new config patch when this is done.

https://gerrit.wikimedia.org/r/366533

gerritbot added a comment.Mar 1 2018, 1:34 PM

Change 366532 abandoned by Thiemo Kreuz (WMDE):
Allow "unitStorage" configuration without referencing class names

Reason:
It makes me sad to see experienced developers not realizing the problem with hard-coded snippets of executable code in configuration strings (a full qualified class name effectively is code). This is guaranteed to break (and already did several times) any time a class is refactored or moved to an other namespace (e.g. to make a codebase PSR-4 compatible). But this is not going to be my problem any more.

https://gerrit.wikimedia.org/r/366532

gerritbot added a comment.May 17 2018, 9:30 AM

Change 366534 abandoned by Thiemo Kreuz (WMDE):
Remove obsolete backwards compatibility code for "unitStorage" config

https://gerrit.wikimedia.org/r/366534

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL