Page MenuHomePhabricator
Create Task
Maniphest T171115

Remove phpcs exceptions and severity 0 from mediawiki-config
Open, LowestPublic
Actions

Description

We now have phpcs passing. We should improve that by removing all exceptions and severity 0 where possible

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+55 -19phpcs: move SpaceBeforeSingleLineComment.NewLineComment exclusions
operations/mediawiki-configmaster+0 -59MWRealm.php: remove unused getRealmSpecificFilename()
operations/mediawiki-configmaster+40 -58phpcs: enable PrefixedGlobalFunctions.allowedPrefix and rename functions
operations/mediawiki-configmaster+167 -81phpcs: fix more SpaceBeforeSingleLineComment.NewLineComment
operations/mediawiki-configmaster+65 -32phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment
operations/mediawiki-configmaster+11 -1phpcs: enable and configure ValidGlobalName.allowedPrefix
operations/mediawiki-configmaster+26 -1phpcs: enable and configure PrefixedGlobalFunctions.allowedPrefix
operations/mediawiki-configmaster+36 -37phpcs: enable and fix MisleadingGlobalNames.Misleading$wgConf
operations/mediawiki-configmaster+3 -1phpcs: move Misleading$wgDebugLogFile exclusion inline
operations/mediawiki-configmaster+19 -5phpcs: enable and fix FunctionComment.WrongStyle
operations/mediawiki-configmaster+2 -4phpcs: move AssignmentInControlStructures exclusion inline
operations/mediawiki-configmaster+1 -3phpcs: move ForbiddenFunctions.exec exclusion inline
operations/mediawiki-configmaster+1 -3phpcs: move ForbiddenFunctions.extract exclusion inline
operations/mediawiki-configmaster+2 -1phpcs: enable and suppress ClassMatchesFilename.NotMatch
operations/mediawiki-configmaster+26 -1phpcs: enable PropertyDocumentation.MissingDocumentationPrivate
operations/mediawiki-configmaster+4 -1phpcs: enable and suppress DuplicateClassName.Found
operations/mediawiki-configmaster+16 -9phpcs: enable PropertyDocumentation.WrongStyle
operations/mediawiki-configmaster+9 -1phpcs: enable FunctionComment.MissingDocumentationPrivate
operations/mediawiki-configmaster+1 -3phpcs: move DisallowYodaConditions exclusion inline
operations/mediawiki-configmaster+32 -2phpcs: add @covers tags to test files
operations/mediawiki-configmaster+4 -2phpcs: enable FunctionComment.MissingParamTag
operations/mediawiki-configmaster+7 -1phpcs: enable PropertyDocumentation.MissingDocumentationProtected
operations/mediawiki-configmaster+0 -1phpcs: rename test files to match class names
operations/mediawiki-configmaster+3 -4phpcs: enable and fix PropertyDocumentation.MissingVar
operations/mediawiki-configmaster+0 -9phpcs: enable rules that are already passing
operations/mediawiki-configmaster+6 -8phpcs: clean up MWConfigCacheGenerator and enable rules
operations/mediawiki-configmaster+9 -6phpcs: narrow some exclusions only needed for cirrusTest.php
operations/mediawiki-configmaster+0 -1phpcs: enable passing rule UnusedGlobalVariables
operations/mediawiki-configmaster+3 -6phpcs: enable and fix SingleSpaceBeforeSingleLineComment
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2017, 10:04 PM
Reedy added a subtask: T162835: Enforce our PHP coding standards on operations/mediawiki-config via composer?.Jul 19 2017, 10:05 PM
DannyS712 claimed this task.Mar 27 2022, 12:42 AM
DannyS712 added a subscriber: DannyS712.

Will do, it will take a while to coordinate with deployment windows though

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 27 2022, 12:42 AM
DannyS712 triaged this task as Lowest priority.Mar 27 2022, 12:45 AM
gerritbot added a comment.Mar 27 2022, 12:46 AM

Change 773863 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and fix SingleSpaceBeforeSingleLineComment

https://gerrit.wikimedia.org/r/773863

gerritbot added a project: Patch-For-Review.Mar 27 2022, 12:46 AM
gerritbot added a comment.Mar 27 2022, 12:52 AM

Change 773864 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and fix UnusedGlobalVariables

https://gerrit.wikimedia.org/r/773864

gerritbot added a comment.Mar 27 2022, 12:56 AM

Change 773865 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: narrow some exclusions only needed for cirrusTest.php

https://gerrit.wikimedia.org/r/773865

gerritbot added a comment.Mar 27 2022, 1:06 AM

Change 773966 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: clean up MWConfigCacheGenerator and enable rules

https://gerrit.wikimedia.org/r/773966

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Mar 27 2022, 1:18 AM
gerritbot added a comment.Mar 28 2022, 1:11 PM

Change 773863 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and fix SingleSpaceBeforeSingleLineComment

https://gerrit.wikimedia.org/r/773863

Stashbot added a comment.Mar 28 2022, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:13:55Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:773863|phpcs: enable and fix SingleSpaceBeforeSingleLineComment (T171115)]] (phpcs.xml will be synced with next patch) (duration: 01m 01s)

gerritbot added a comment.Mar 28 2022, 1:15 PM

Change 773864 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable passing rule UnusedGlobalVariables

https://gerrit.wikimedia.org/r/773864

Stashbot added a comment.Mar 28 2022, 1:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:17:55Z] <lucaswerkmeister-wmde@deploy1002> Synchronized phpcs.xml: Config: [[gerrit:773864|phpcs: enable passing rule UnusedGlobalVariables (T171115)]] (includes phpcs.xml change from previous sync) (duration: 00m 56s)

gerritbot added a comment.Mar 28 2022, 1:20 PM

Change 773865 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: narrow some exclusions only needed for cirrusTest.php

https://gerrit.wikimedia.org/r/773865

Stashbot added a comment.Mar 28 2022, 1:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:21:58Z] <lucaswerkmeister-wmde@deploy1002> Synchronized tests/cirrusTest.php: Config: [[gerrit:773865|phpcs: narrow some exclusions only needed for cirrusTest.php (T171115)]] (1/2) (duration: 00m 56s)

Stashbot added a comment.Mar 28 2022, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:23:03Z] <lucaswerkmeister-wmde@deploy1002> Synchronized phpcs.xml: Config: [[gerrit:773865|phpcs: narrow some exclusions only needed for cirrusTest.php (T171115)]] (2/2) (duration: 00m 55s)

gerritbot added a comment.Mar 31 2022, 2:11 AM

Change 775005 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable rules that are already passing

https://gerrit.wikimedia.org/r/775005

gerritbot added a comment.Mar 31 2022, 2:15 AM

Change 775426 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: rename test files to match class names

https://gerrit.wikimedia.org/r/775426

gerritbot added a comment.Mar 31 2022, 2:27 AM

Change 775427 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and fix PropertyDocumentation.MissingVar

https://gerrit.wikimedia.org/r/775427

gerritbot added a comment.Mar 31 2022, 2:36 AM

Change 773966 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: clean up MWConfigCacheGenerator and enable rules

https://gerrit.wikimedia.org/r/773966

gerritbot added a comment.Mar 31 2022, 8:38 PM

Change 775005 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable rules that are already passing

https://gerrit.wikimedia.org/r/775005

gerritbot added a comment.Mar 31 2022, 8:41 PM

Change 775426 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: rename test files to match class names

https://gerrit.wikimedia.org/r/775426

gerritbot added a comment.Mar 31 2022, 8:43 PM

Change 775427 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and fix PropertyDocumentation.MissingVar

https://gerrit.wikimedia.org/r/775427

Stashbot added a comment.Mar 31 2022, 8:46 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:46:14Z] <thcipriani@deploy1002> Synchronized phpcs.xml: Config (noop): [[gerrit:775427|phpcs: enable and fix PropertyDocumentation.MissingVar (T171115)]] [[gerrit:775426|phpcs: rename test files to match class names (T171115)]] [[gerrit:775005|phpcs: enable rules that are already passing (T171115)]] (duration: 00m 49s)

Stashbot added a comment.Mar 31 2022, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:47:41Z] <thcipriani@deploy1002> Synchronized src/StaticSiteConfiguration.php: Config (noop -- comment change): [[gerrit:775427|phpcs: enable and fix PropertyDocumentation.MissingVar (T171115)]] (duration: 00m 50s)

gerritbot added a comment.Mar 31 2022, 9:57 PM

Change 775937 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.MissingDocumentationProtected

https://gerrit.wikimedia.org/r/775937

gerritbot added a comment.Mar 31 2022, 10:01 PM

Change 775938 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable FunctionComment.MissingParamTag

https://gerrit.wikimedia.org/r/775938

gerritbot added a comment.Mar 31 2022, 10:04 PM

Change 775939 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: add @covers tags to test files

https://gerrit.wikimedia.org/r/775939

gerritbot added a comment.May 23 2022, 6:54 AM

Change 796352 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move DisallowYodaConditions exclusion inline

https://gerrit.wikimedia.org/r/796352

gerritbot added a comment.May 23 2022, 6:58 AM

Change 796353 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable FunctionComment.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/796353

gerritbot added a comment.May 23 2022, 7:13 AM

Change 796354 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.WrongStyle

https://gerrit.wikimedia.org/r/796354

gerritbot added a comment.May 23 2022, 7:19 AM

Change 796355 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and suppress DuplicateClassName.Found

https://gerrit.wikimedia.org/r/796355

gerritbot added a comment.May 23 2022, 7:27 AM

Change 796356 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/796356

gerritbot added a comment.May 23 2022, 7:31 AM

Change 775937 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.MissingDocumentationProtected

https://gerrit.wikimedia.org/r/775937

gerritbot added a comment.May 23 2022, 7:31 AM

Change 775938 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable FunctionComment.MissingParamTag

https://gerrit.wikimedia.org/r/775938

gerritbot added a comment.May 23 2022, 7:35 AM

Change 775939 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: add @covers tags to test files

https://gerrit.wikimedia.org/r/775939

gerritbot added a comment.May 23 2022, 7:35 AM

Change 796352 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move DisallowYodaConditions exclusion inline

https://gerrit.wikimedia.org/r/796352

gerritbot added a comment.May 23 2022, 7:38 AM

Change 796353 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable FunctionComment.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/796353

gerritbot added a comment.May 23 2022, 7:38 AM

Change 796354 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.WrongStyle

https://gerrit.wikimedia.org/r/796354

gerritbot added a comment.May 23 2022, 7:41 AM

Change 796357 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and suppress ClassMatchesFilename.NotMatch

https://gerrit.wikimedia.org/r/796357

gerritbot added a comment.May 23 2022, 7:42 AM

Change 796355 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and suppress DuplicateClassName.Found

https://gerrit.wikimedia.org/r/796355

gerritbot added a comment.May 23 2022, 7:46 AM

Change 796356 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable PropertyDocumentation.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/796356

gerritbot added a comment.May 23 2022, 7:47 AM

Change 796357 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and suppress ClassMatchesFilename.NotMatch

https://gerrit.wikimedia.org/r/796357

gerritbot added a comment.May 23 2022, 7:47 AM

Change 796358 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move ForbiddenFunctions.extract exclusion inline

https://gerrit.wikimedia.org/r/796358

gerritbot added a comment.May 23 2022, 7:48 AM

Change 796359 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move ForbiddenFunctions.exec exclusion inline

https://gerrit.wikimedia.org/r/796359

gerritbot added a comment.May 23 2022, 7:50 AM

Change 796358 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move ForbiddenFunctions.extract exclusion inline

https://gerrit.wikimedia.org/r/796358

gerritbot added a comment.May 23 2022, 7:51 AM

Change 796360 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable passing AssignmentInControlStructures rule

https://gerrit.wikimedia.org/r/796360

gerritbot added a comment.May 23 2022, 7:53 AM

Change 796359 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move ForbiddenFunctions.exec exclusion inline

https://gerrit.wikimedia.org/r/796359

gerritbot added a comment.Jun 6 2022, 1:08 AM

Change 802840 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move Misleading$wgDebugLogFile exclusion inline

https://gerrit.wikimedia.org/r/802840

gerritbot added a comment.Jun 6 2022, 1:12 AM

Change 802841 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and fix FunctionComment.WrongStyle

https://gerrit.wikimedia.org/r/802841

gerritbot added a comment.Jun 6 2022, 1:24 AM

Change 802842 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and configure ValidGlobalName.allowedPrefix

https://gerrit.wikimedia.org/r/802842

gerritbot added a comment.Jun 6 2022, 4:13 AM

Change 802946 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable and configure PrefixedGlobalFunctions.allowedPrefix

https://gerrit.wikimedia.org/r/802946

gerritbot added a comment.Jun 6 2022, 4:22 AM

Change 802947 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move Misleading$wgConf exclusion inline

https://gerrit.wikimedia.org/r/802947

gerritbot added a comment.Jun 14 2022, 8:23 PM

Change 796360 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move AssignmentInControlStructures exclusion inline

https://gerrit.wikimedia.org/r/796360

gerritbot added a comment.Jun 14 2022, 8:23 PM

Change 802840 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move Misleading$wgDebugLogFile exclusion inline

https://gerrit.wikimedia.org/r/802840

gerritbot added a comment.Jun 14 2022, 8:23 PM

Change 802841 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and fix FunctionComment.WrongStyle

https://gerrit.wikimedia.org/r/802841

gerritbot added a comment.Jun 14 2022, 8:23 PM

Change 802842 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and configure ValidGlobalName.allowedPrefix

https://gerrit.wikimedia.org/r/802842

gerritbot added a comment.Jun 14 2022, 8:25 PM

Change 802946 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and configure PrefixedGlobalFunctions.allowedPrefix

https://gerrit.wikimedia.org/r/802946

gerritbot added a comment.Jun 14 2022, 8:25 PM

Change 802947 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable and fix MisleadingGlobalNames.Misleading$wgConf

https://gerrit.wikimedia.org/r/802947

Stashbot added a comment.Jun 14 2022, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T20:31:10Z] <urbanecm@deploy1002> Synchronized wmf-config/: phpcs cleanups (T171115; no-op for production) (duration: 03m 38s)

Stashbot added a comment.Jun 14 2022, 8:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T20:34:39Z] <urbanecm@deploy1002> Synchronized multiversion/: phpcs cleanups (T171115; no-op for production) (duration: 03m 28s)

Stashbot added a comment.Jun 14 2022, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T20:37:55Z] <urbanecm@deploy1002> Synchronized w/: phpcs cleanups (T171115; no-op for production) (duration: 03m 15s)

Stashbot added a comment.Jun 14 2022, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T20:41:36Z] <urbanecm@deploy1002> Synchronized docroot/: phpcs cleanups (T171115; no-op for production) (duration: 03m 41s)

gerritbot added a comment.Jun 14 2022, 8:59 PM

Change 805430 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment

https://gerrit.wikimedia.org/r/805430

gerritbot added a comment.Jun 14 2022, 9:45 PM

Change 805430 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment

https://gerrit.wikimedia.org/r/805430

gerritbot added a comment.Jun 14 2022, 9:47 PM

Change 805431 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: fix more SpaceBeforeSingleLineComment.NewLineComment

https://gerrit.wikimedia.org/r/805431

Stashbot added a comment.Jun 14 2022, 9:51 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T21:51:27Z] <urbanecm@deploy1002> Synchronized docroot/: ca3b94f2d9bc755d92839e5e69072615ea9008df: phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 38s)

Stashbot added a comment.Jun 14 2022, 9:54 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T21:54:58Z] <urbanecm@deploy1002> Synchronized multiversion/: ca3b94f2d9bc755d92839e5e69072615ea9008df: phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 29s)

Stashbot added a comment.Jun 14 2022, 9:58 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T21:58:27Z] <urbanecm@deploy1002> Synchronized rpc/: ca3b94f2d9bc755d92839e5e69072615ea9008df: phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 31s)

Stashbot added a comment.Jun 14 2022, 10:02 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T22:02:00Z] <urbanecm@deploy1002> Synchronized src/: ca3b94f2d9bc755d92839e5e69072615ea9008df: phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 32s)

Stashbot added a comment.Jun 14 2022, 10:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T22:05:19Z] <urbanecm@deploy1002> Synchronized w/: ca3b94f2d9bc755d92839e5e69072615ea9008df: phpcs: start to fix SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 18s)

gerritbot added a comment.Jun 14 2022, 10:10 PM

Change 805431 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: fix more SpaceBeforeSingleLineComment.NewLineComment

https://gerrit.wikimedia.org/r/805431

Stashbot added a comment.Jun 14 2022, 10:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T22:15:03Z] <urbanecm@deploy1002> Synchronized wmf-config/: e3fe6c04c95717f0f914bbfa366f5f827f392b6b: phpcs: fix more SpaceBeforeSingleLineComment.NewLineComment (T171115) (duration: 03m 39s)

gerritbot added a comment.Jun 14 2022, 10:25 PM

Change 805432 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: move SpaceBeforeSingleLineComment.NewLineComment exclusions

https://gerrit.wikimedia.org/r/805432

gerritbot added a comment.Jun 16 2022, 8:08 PM

Change 806248 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] phpcs: enable PrefixedGlobalFunctions.allowedPrefix and rename functions

https://gerrit.wikimedia.org/r/806248

gerritbot added a comment.Jun 16 2022, 8:15 PM

Change 805432 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: move SpaceBeforeSingleLineComment.NewLineComment exclusions

https://gerrit.wikimedia.org/r/805432

gerritbot added a comment.Jun 16 2022, 8:18 PM

Change 806249 had a related patch set uploaded (by DannyS712; author: DannyS712):

[operations/mediawiki-config@master] MWRealm.php: remove unused getRealmSpecificFilename()

https://gerrit.wikimedia.org/r/806249

Stashbot added a comment.Jun 16 2022, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T20:23:29Z] <cjming@deploy1002> Synchronized wmf-config/: Config: [[gerrit:805432|phpcs: move SpaceBeforeSingleLineComment.NewLineComment exclusions (T171115)]] (duration: 03m 22s)

Stashbot added a comment.Jun 16 2022, 8:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T20:27:22Z] <cjming@deploy1002> Synchronized phpcs.xml: Config: [[gerrit:805432|phpcs: move SpaceBeforeSingleLineComment.NewLineComment exclusions (T171115)]] (duration: 03m 27s)

gerritbot added a comment.Jun 16 2022, 8:33 PM

Change 806248 merged by jenkins-bot:

[operations/mediawiki-config@master] phpcs: enable PrefixedGlobalFunctions.allowedPrefix and rename functions

https://gerrit.wikimedia.org/r/806248

Stashbot added a comment.Jun 16 2022, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T20:42:01Z] <thcipriani@deploy1002> Started scap: Config: [[gerrit:806248|phpcs: enable PrefixedGlobalFunctions.allowedPrefix and rename functions (T171115)]]

gerritbot added a comment.Jun 16 2022, 8:43 PM

Change 806249 merged by jenkins-bot:

[operations/mediawiki-config@master] MWRealm.php: remove unused getRealmSpecificFilename()

https://gerrit.wikimedia.org/r/806249

Stashbot added a comment.Jun 16 2022, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T20:58:58Z] <thcipriani@deploy1002> Finished scap: Config: [[gerrit:806248|phpcs: enable PrefixedGlobalFunctions.allowedPrefix and rename functions (T171115)]] (duration: 16m 57s)

Stashbot added a comment.Jun 16 2022, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T21:06:28Z] <thcipriani@deploy1002> Synchronized multiversion/MWRealm.php: Config: [[gerrit:806249|MWRealm.php: remove unused getRealmSpecificFilename() (T171115)]] (duration: 03m 35s)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL