Page MenuHomePhabricator
Create Task
Maniphest T171129

[betalabs-regression] RC page - "No active filters. All contributions are shown" text is missing when default filters dismissed
Closed, ResolvedPublic
Actions

Description

  1. In betalabs dismiss the default filter selection (click on the trash icon).
  2. The filters will be dismissed, but the text "No active filters. All contributions are shown" won't be shown. "REstore default filters" text won't be either.

Compare enwiki wmf.9:

Screen Shot 2017-07-19 at 4.35.59 PM.png (278×1 px, 53 KB)

betalabs (clicking on the trash bin icon will restore default filters):

Screen Shot 2017-07-19 at 12.48.17 PM.png (436×1 px, 101 KB)

Note: reload the page - the default filters will be back.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' querymediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jul 19 2017, 11:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2017, 11:40 PM
Etonkovidova updated the task description. (Show Details)Jul 19 2017, 11:41 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 20 2017, 6:50 PM
gerritbot subscribed.Jul 20 2017, 11:07 PM

Change 366753 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' query

https://gerrit.wikimedia.org/r/366753

gerritbot added a project: Patch-For-Review.Jul 20 2017, 11:07 PM
Mooeypoo claimed this task.Jul 20 2017, 11:07 PM
Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 21 2017, 12:04 AM
gerritbot added a comment.Jul 21 2017, 12:11 AM

Change 366753 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' query

https://gerrit.wikimedia.org/r/366753

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 21 2017, 1:00 AM
Etonkovidova added a comment.Jul 21 2017, 10:16 PM

The fix is checked - all works as expected.

Etonkovidova closed this task as Resolved.Jul 21 2017, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits