Page MenuHomePhabricator

[betalabs-regression] RC page - "No active filters. All contributions are shown" text is missing when default filters dismissed
Closed, ResolvedPublic

Description

  1. In betalabs dismiss the default filter selection (click on the trash icon).
  2. The filters will be dismissed, but the text "No active filters. All contributions are shown" won't be shown. "REstore default filters" text won't be either.

Compare enwiki wmf.9:

betalabs (clicking on the trash bin icon will restore default filters):

Note: reload the page - the default filters will be back.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2017, 11:40 PM

Change 366753 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' query

https://gerrit.wikimedia.org/r/366753

Change 366753 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Exclude 'hidden' filters from 'areCurrentFiltersEmpty' query

https://gerrit.wikimedia.org/r/366753

The fix is checked - all works as expected.

Etonkovidova closed this task as Resolved.Jul 21 2017, 10:16 PM