Tapping left or right of the text slider does not change the text size
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Fjalapeno
	Jul 20 2017, 6:48 PM

Description

How many times were you able to reproduce it?

Steps to reproduce

Open Article View
Open text slider
Tap to the left or right of the thumb

Expected results

The slider should move to the tick mark closest to where you tapped

Actual results

Nothing

Environments observed

App version: 5.6
OS versions: 11 beta
Device model: iPhone 7
Device language: en

Related Objects

Mentioned In: rAPIOS115328fd6b35: Merge pull request #1716 from wikimedia/bug/T171204
rAPIOSa375afebd9bd: Merge branch 'bug/T171204' of https://github.com/wikimedia/wikipedia-ios into…
rAPIOS1c58b1c69d88: Merge branch 'develop' into bug/T171204
rAPIOSdd0d0b912910: Merge branch 'develop' into bug/T171204
rAPIOS4a473109ba2e: Merge branch 'develop' into bug/T171204
rAPIOSbf62b33c2b8e: Merge branch 'develop' into bug/T171204
rAPIOSdc4a627726b3: Merge branch 'develop' into bug/T171204
rAPIOS3bbbe443451f: Merge branch 'develop' into bug/T171204

Event Timeline

• Fjalapeno created this task.Jul 20 2017, 6:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2017, 6:48 PM

• Fjalapeno added a project: iOS-app-Bugs.Jul 20 2017, 6:48 PM

• JMinor triaged this task as Low priority.Jul 24 2017, 7:27 PM

• JMinor added a project: iOS-app-v5.6.0-Goat-On-A-Train.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Not a regression in 5.6. Same behavior on 5.5.1. I would also argue that this isn't expected behavior, the text size slider in system prefs doesn't increment/decrement with a tap on either side.

JoeWalsh removed a project: Regression.Jul 25 2017, 2:49 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 25 2017, 6:17 PM

• JMinor edited projects, added iOS-app-v5.6.1-Goat-On-A-Plane; removed iOS-app-v5.6.0-Goat-On-A-Train.Aug 1 2017, 5:43 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 1 2017, 6:34 PM

Diffusion mentioned this in rAPIOS3bbbe443451f: Merge branch 'develop' into bug/T171204.Aug 7 2017, 3:05 PM

Diffusion mentioned this in rAPIOSdc4a627726b3: Merge branch 'develop' into bug/T171204.

Diffusion mentioned this in rAPIOSbf62b33c2b8e: Merge branch 'develop' into bug/T171204.

Diffusion mentioned this in rAPIOS4a473109ba2e: Merge branch 'develop' into bug/T171204.

Different solution - instead of incrementing/decrementing 1 step, allow the user to tap the preferred step.

gif

• NHarateh_WMF claimed this task.Aug 7 2017, 5:20 PM

• NHarateh_WMF moved this task from Needs Acceptance Criteria to Doing on the iOS-app-v5.6.1-Goat-On-A-Plane board.

JoeWalsh mentioned this in rAPIOSdd0d0b912910: Merge branch 'develop' into bug/T171204.Aug 7 2017, 7:54 PM

Diffusion mentioned this in rAPIOS1c58b1c69d88: Merge branch 'develop' into bug/T171204.Aug 7 2017, 7:55 PM

Diffusion mentioned this in rAPIOSa375afebd9bd: Merge branch 'bug/T171204' of https://github.com/wikimedia/wikipedia-ios into….

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 7 2017, 7:58 PM

Per grooming, @NHarateh_WMF solution looks fine to me...

JoeWalsh mentioned this in rAPIOS115328fd6b35: Merge pull request #1716 from wikimedia/bug/T171204.Aug 8 2017, 11:50 AM

• NHarateh_WMF moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 8 2017, 12:49 PM

• NHarateh_WMF set the point value for this task to 1.Aug 8 2017, 7:18 PM

JoeWalsh updated the task description. (Show Details)Aug 9 2017, 1:17 PM

JoeWalsh moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.

Looks good @NHarateh_WMF !

Tested on iPad Pro with iOS 10.3.3 and iPhone 7+ with iOS 10.3.3 on App 5.6.1 (1199)

Looks good to me. Very tappy.

Very tappy. Boo.

Tapping left or right of the text slider does not change the text sizeClosed, ResolvedPublic1 Estimated Story PointsActions