Page MenuHomePhabricator

Multiple callout cards at the top of the feed for new users
Closed, ResolvedPublic

Description

Repro steps

  1. Clean install
  2. View the explore feed

Expected behavior

I'd like to see only one feature called out above feed content

Actual behavior

There are two features called out above feed content

a.gif (668×376 px, 746 KB)

Proposed Solution

Move the news notification card below the news card, only add it when there's news.

Simulator Screen Shot Jul 21, 2017, 7.15.37 AM.png (1×750 px, 229 KB)

Event Timeline

JoeWalsh renamed this task from Move the notification feed card below the News card, only add it when there's news to Fix excessive callout cards at the top of the feed for new users.Jul 21 2017, 1:11 PM
JoeWalsh renamed this task from Fix excessive callout cards at the top of the feed for new users to Multiple callout cards at the top of the feed for new users.
JoeWalsh updated the task description. (Show Details)
JoeWalsh updated the task description. (Show Details)
JoeWalsh updated the task description. (Show Details)
JMinor triaged this task as Medium priority.Jul 21 2017, 5:47 PM
JMinor subscribed.

Per our convo, this change in logic makes sense, especially paired with a design update to the call out.

Lets also check that this works for iPad.

@JMinor guessing you meant to move this to ready for dev?

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1189). This is fixed according to the screencaps below.

T171299 Only one feature called out above feed content.PNG (1×750 px, 251 KB)
T171299 News notification card below the news card.PNG (1×750 px, 150 KB)

ABorbaWMF subscribed.

Tested on iPad Pro with iOS 10.3.3 and iPhone 7+ with iOS 10.3.3 on App 5.6.0 (1190)

Both callouts looks good