Notifications flyout footer has an unwanted margin
Closed, ResolvedPublic
Actions

Description

Seen on all wikis I've visited today, on Firefox or Chromium: an important margin, tabs are offset and there is a grey background.

One example among many:

Capture d’écran_2017-07-21_15-32-13.png (280×566 px, 31 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix layout regression in notification popup footer	mediawiki/extensions/Echo	wmf/1.30.0-wmf.10	+3 -0
	Fix layout regression in notification popup footer	mediawiki/extensions/Echo	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned Here: rGOJUe5a613ea173d: WikimediaUI theme: Variablize PopupWidget values

Event Timeline

Trizek-WMF created this task.Jul 21 2017, 1:36 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 21 2017, 1:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Srdjan subscribed.Jul 21 2017, 4:20 PM

Margin's coming from the .oo-ui-popupWidget-footer class. Maybe it's new? I guess Notifications should null it back out, at least for now.

Jdforrester-WMF renamed this task from Notifications flyout buttons have a design problem to Notifications flyout footer has an unwanted margin.Jul 21 2017, 5:13 PM

Probably a regression from rGOJUe5a613ea173d: WikimediaUI theme: Variablize PopupWidget values which added margin to the footer without justifying it in the commit message.

Change 366903 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] Fix layout regression in notification popup footer

https://gerrit.wikimedia.org/r/366903

gerritbot added a project: Patch-For-Review.Jul 21 2017, 8:05 PM

Change 366903 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix layout regression in notification popup footer

https://gerrit.wikimedia.org/r/366903

Change 366952 had a related patch set uploaded (by Jforrester; owner: Catrope):
[mediawiki/extensions/Echo@wmf/1.30.0-wmf.10] Fix layout regression in notification popup footer

https://gerrit.wikimedia.org/r/366952

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 21 2017, 9:00 PM

Trizek-WMF added a project: User-notice.Jul 24 2017, 9:51 AM

Change 366952 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.30.0-wmf.10] Fix layout regression in notification popup footer

https://gerrit.wikimedia.org/r/366952

Mentioned in SAL (#wikimedia-operations) [2017-07-24T18:15:17Z] <reedy@tin> Synchronized php-1.30.0-wmf.10/extensions/Echo/modules/styles/mw.echo.ui.NotificationBadgeWidget.less: T171302 (duration: 00m 45s)

Catrope closed this task as Resolved.Jul 24 2017, 6:30 PM

Catrope claimed this task.

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 24 2017, 7:00 PM

Jdforrester-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Patch-For-Review, Collaboration-Team-Triage.Jul 24 2017, 7:29 PM

Jdforrester-WMF moved this task from Untriaged to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.