| Mhurd | |
| Jul 21 2017, 5:00 PM |
| F8849733: device-2017-07-25-123520.png | |
| Jul 25 2017, 4:37 PM |
| F8824319: Screenshot_1500861089.png | |
| Jul 24 2017, 1:53 AM |
| F8824320: Screenshot_1500861081.png | |
| Jul 24 2017, 1:53 AM |
| F8807586: screenshot-2017-07-21-12-23-58-259666208.png | |
| Jul 21 2017, 5:31 PM |
| F8807590: screenshot-2017-07-21-12-21-33-009749588.png | |
| Jul 21 2017, 5:31 PM |
| F8807588: screenshot-2017-07-21-12-24-39-644428530.png | |
| Jul 21 2017, 5:31 PM |
| F8807587: screenshot-2017-07-21-12-20-47-242517449.png | |
| Jul 21 2017, 5:31 PM |
| F8807589: screenshot-2017-07-21-12-25-00-291763958.png | |
| Jul 21 2017, 5:31 PM |
Note - Theme issues with Edit Previews are handled here https://phabricator.wikimedia.org/T174842
enwiki > Mycenaean Greek
on edit preview on first section
Non-edit preview presentations issues are listed below.
on non-edit preview presentation of the article if you un-collapse the first table
enwiki > John McCain
enwiki > Chris Cornell
enwiki > Audioslave
enwiki > Toast
enwiki > Mathematics
enwiki > Manchester United F.C.
enwiki > Gantz
enwiki > Kill 'Em All > Music and lyrics
If this is edit preview only, is this an issue with the integration or page library?
pagelib theme transform when applied to edit preview html
@Niedzielski I may amend the description to include some other missing bits which may affect the regular article presentation (as opposed to the edit preview html).
@Niedzielski do you know of any other 'sore thumb' theming areas we could add to this ticket? Hoping to knock out as much low-hanging fruit as possible in one pass if we can...
I think there are some on the tables in https://fr.m.wikipedia.org/wiki/Liste_de_sondages_sur_l%27%C3%A9lection_pr%C3%A9sidentielle_fran%C3%A7aise_de_2017?oldid=138519598 and the infobox for French Obama. Visit a non-English wiki or a non-mainspace page and I'm sure you will be able to identify many more.
@JMinor I threw this on Goat, but lemme know if you want to wait. My preference would be to knock these out now. I don't think it would take very long - these are pretty easy to test :)
I think there are some on the tables in https://fr.m.wikipedia.org/wiki/Liste_de_sondages_sur_l%27%C3%A9lection_pr%C3%A9sidentielle_fran%C3%A7aise_de_2017?oldid=138519598 and the infobox for French Obama. Visit a non-English wiki or a non-mainspace page and I'm sure you will be able to identify many more.
Oh good idea!
^^^ @ABorbaWMF, this would be a good opportunity for some further exploratory testing and bug reporting!
Per our standup, lets definitely tackle these (and any others we find) over the course of the beta.
Parking this in Needs Acceptance, so we can add to the list before we pull into development.
Before/afters screenshots for fixable issues are up on https://github.com/wikimedia/wikimedia-page-library/pull/77
Per our meeting, there's enough change risk here that this should not be merged until 5.6.1
This PR has 79 commits over 12 days and is still marked WIP. 1 point can't be right! :]
@Niedzielski we don't point by complexity ;) The point was an attempt to use the point system for Kanban task limiters, but it didn't work.
Testing criteria: