| RHo | |
| Jul 21 2017, 5:02 PM |
| F8988834: Screenshot_20170808-204326.png | |
| Aug 9 2017, 8:03 AM |
| F8993988: main-MainActivity-08092017100204.png | |
| Aug 9 2017, 8:03 AM |
| F8988836: Screenshot_20170808-204329.png | |
| Aug 9 2017, 8:03 AM |
| F8988778: main-MainActivity-08082017202625.png | |
| Aug 9 2017, 8:03 AM |
| F8993984: main-MainActivity-08092017100132.png | |
| Aug 9 2017, 8:03 AM |
| F8882987: Feed spacing on single and multi-column.png | |
| Jul 28 2017, 12:23 PM |
| F5006990: In the news - multi-column layout.png | |
| Jul 21 2017, 5:02 PM |
| F8807177: Screenshot_20170721-173752.png | |
| Jul 21 2017, 5:02 PM |
The unexpected behavior is evident when the feed is shown in multiple columns on tablets and landscape mode on larger devices.
Search bar appears in the flex space of the Explore tool bar outside of the card content shown in columns.
Search bar is the first item in the feed and appears within the first column of cards.
Change 368104 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Set full span layout parameter on SearchCardView
Change 368174 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Limit width of search box in the feed.
Change 368104 merged by jenkins-bot:
[apps/android/wikipedia@master] Set full span layout parameter on SearchCardView
Change 368174 merged by jenkins-bot:
[apps/android/wikipedia@master] Limit width of search box in the feed.
hi Michael – looks great! I should have fleshed out details about the width of the search bar when in multiple card mode (if cards are in single column the search bar is the same width as the cards). Will post detailed spec for that tomorrow!
Hey @Mholloway – here's the red line with the search width behavior, whereby on single columns the width is the same as the cards, but in multi-column mode it is 2/3rd of the total card content width.
Change 368944 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Feed design tweaks, pt. 1: adjust card margins
Change 368944 merged by jenkins-bot:
[apps/android/wikipedia@master] Feed design tweaks, pt. 1: adjust card margins
Change 369433 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Feed design tweak #2: Update search bar width limiting
Change 369433 merged by jenkins-bot:
[apps/android/wikipedia@master] Feed design tweak #2: Update search bar width limiting
This looks great!
Nexus 5  | Pixel  | Pixel landscape  | Nexus 7  | Nexus 7 landscape  |
Test using Nexus 5 (Android 6.0.1), Pixel (7.1.2) and Nexus 7 () on Wikipedia v2.6.200-alpha-2017-08-08
Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-11
Looks good to me too.