Page MenuHomePhabricator

[wmf.10] Long LTR article titles displayed cut off on the list of suggestions in RTL
Closed, ResolvedPublic

Description

  1. In hewiki go to Translation and select to translate from English to Hebrew
  2. Click 'Start new translation' and enter some short article title - 'Robot'. The suggestions will be displayed correctly (there is a typical issue with the order of parentheses) :
    Screen Shot 2017-07-21 at 12.49.41 PM.png (469×778 px, 112 KB)
  3. Start typing the long article title - 'List of law clerks of the Supreme Court of the United States' - the beginning of the article titles gets cut off.

Screen Shot 2017-07-20 at 4.58.43 PM.png (614×900 px, 135 KB)

Event Timeline

Amire80 subscribed.

Mmmm... I'm afraid it's a bug in browsers, or even in the HTML spec, because it happens on a lot of otherwise well-behaving sites. But I'll try to take a closer look.

Arrbee triaged this task as Medium priority.
Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.
Arrbee added a project: Language-2017-Oct-Dec.

This is still present in the new article selector.

The problem is that the text doesn't have correct lang and dir attributes.

The title must definitely have lang and dir attributes of the target article.

I'm not sure about the Wikidata description; is it displayed in the user language or in the same language as the article title?

This looks good. Is it with an RTL UI language?

Not sure about the placement of the "A文" icon—that's a question for Pau. In any case, it should be the same, and depend on the UI language and not on target article content language.

Yeah it's RTL ui selecting Finnish pages.

Change 389054 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Some RTL improvements to the page selector

https://gerrit.wikimedia.org/r/389054

Change 389054 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Some RTL improvements to the page selector

https://gerrit.wikimedia.org/r/389054

Checked in cx-testing - looks good:

Screen Shot 2017-11-30 at 3.26.56 PM.png (531×940 px, 104 KB)