Page MenuHomePhabricator
Create Task
Maniphest T171351

Are PayPal refunds for recurring donations incorrectly being tagged as EC or vice versa?
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

See for example https://civicrm.wikimedia.org/damaged/26130

The refund message is tagged with gateway paypal_ec, so the refund consumer is looking for something with trxn_id=PAYPAL_EC <parent_id>. That doesn't exist, but RECURRING PAYPAL <parent_id> does.

This recent refund should have been marked paypal_ec:
https://civicrm.wikimedia.org/damaged/26867

Details

SubjectRepoBranchLines +/-
Fix PayPal Gateway Taggingwikimedia/fundraising/SmashPigmaster+109 -14
Tag refunds and chargebacks with correct paypal gatewaywikimedia/fundraising/SmashPigmaster+79 -28
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Jul 21 2017, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2017, 9:53 PM
Ejegg renamed this task from Are PayPal refunds for recurring donations incorrectly being tagged as EC? to Are PayPal refunds for recurring donations incorrectly being tagged as EC or vice versa?.Jul 21 2017, 9:58 PM
Ejegg triaged this task as High priority.
Ejegg updated the task description. (Show Details)
gerritbot subscribed.Jul 21 2017, 10:35 PM

Change 366976 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] WIP Tag refunds with correct paypal gateway

https://gerrit.wikimedia.org/r/366976

gerritbot added a project: Patch-For-Review.Jul 21 2017, 10:35 PM
• DStrine added projects: Fundraising Sprint Navel Warfare, Unplanned-Sprint-Work.Jul 25 2017, 7:42 PM
• DStrine moved this task from Triage to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Navel Warfare board.Jul 25 2017, 9:13 PM
• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM
XenoRyet claimed this task.Aug 4 2017, 5:51 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Outie Inverter board.
• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Prank Seatbelt board.Aug 17 2017, 6:56 PM
XenoRyet moved this task from Doing to Review on the Fundraising Sprint Prank Seatbelt board.Aug 24 2017, 6:21 PM
gerritbot added a comment.Aug 25 2017, 8:12 PM

Change 366976 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Tag refunds and chargebacks with correct paypal gateway

https://gerrit.wikimedia.org/r/366976

XenoRyet moved this task from Review to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.Aug 28 2017, 5:24 PM
XenoRyet moved this task from Pending Deployment to Done on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 7:11 PM
Ejegg added a comment.Aug 29 2017, 8:09 PM

@XenoRyet want to try clearing out the 'damaged' table by swapping paypal and paypal_ec on the NO_PREDECESSOR refunds?

XenoRyet added a comment.Aug 29 2017, 11:39 PM

@Ejegg All cleaned up.

XenoRyet added a comment.Aug 30 2017, 12:03 AM

Or not. Looks like they all went back to the damaged table.

• DStrine added a project: Fundraising Sprint Quill Pencil.Aug 30 2017, 8:21 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Quill Pencil board.Aug 30 2017, 10:01 PM
XenoRyet added a comment.Aug 30 2017, 10:41 PM

From recent failmail looks like there is more than one reason code that means 'refund' and also our assumptions about what a legacy message looks like are no longer true.

gerritbot added a comment.Aug 30 2017, 11:49 PM

Change 374913 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[wikimedia/fundraising/SmashPig@master] WIP Fix PayPal Gateway Tagging

https://gerrit.wikimedia.org/r/374913

XenoRyet moved this task from Doing to Review on the Fundraising Sprint Quill Pencil board.Sep 4 2017, 11:05 PM
XenoRyet moved this task from Review to Doing on the Fundraising Sprint Quill Pencil board.Sep 5 2017, 8:08 PM
XenoRyet moved this task from Doing to Review on the Fundraising Sprint Quill Pencil board.Sep 7 2017, 7:00 PM
gerritbot added a comment.Sep 7 2017, 8:57 PM

Change 374913 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Fix PayPal Gateway Tagging

https://gerrit.wikimedia.org/r/374913

XenoRyet moved this task from Review to Done on the Fundraising Sprint Quill Pencil board.Sep 8 2017, 1:56 AM
XenoRyet set the point value for this task to 4.
XenoRyet closed this task as Resolved.Sep 13 2017, 8:11 PM
XenoRyet mentioned this in T175862: Clean up Damaged queue.Sep 13 2017, 8:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL