recheck is ignored if there are inline comments, even if the top-level/cover comment is only "recheck" (https://gerrit.wikimedia.org/r/#/c/349977).
This is particularly annoying, since there is no way to submit only a top-level comment if you have inline comments.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Recognize recheck with inline comments, too | integration/config | master | +43 -1 |
The detection is based on a regular expression in integration/config zuul/layout.yaml:
comment: (?im)^Patch Set \d+:( -?Code\-Review(\+|-)?(1|2)?)?\n\n\s*recheck\.?\s*$
@Florian tweaked it months ago c8c02b8e5be1f3d5a45b8110162b72b138b2c171 and introduced unit tests to assist :] In
tests/test_zuul_scheduler.py -> def test_recheck*
Aha, interesting, I haven't thought about that so far :)
However, the syntax of the comment looks pretty easy in this case, too:
Patch Set 1:\n\n(1 comment)\n\nrecheck Patch Set 1: Code-Review+1\n\n(1 comment)\n\nrecheck Patch Set 1: -Code-Review\n\n(2 comments)\n\nrecheck
I'll take a look into it and propose a change for our config :)
Change 367691 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[integration/config@master] Recognize recheck with inline comments, too
Change 367691 merged by jenkins-bot:
[integration/config@master] Recognize recheck with inline comments, too