Page MenuHomePhabricator
Create Task
Maniphest T171353

Investigate OTRS report that when logged in edits appear unattributed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10129479

I've reported this before. The app will show me as logged in. But I am actually logged out. My edits thereby appear as IP edits. I'm on an iPhone 7 with all the updates. Thanks. User:srich32977 Version: WikipediaApp/5.5.1.1164 (iOS 10.3.2; Phone)

Related Objects

Event Timeline

Mhurd created this task.Jul 21 2017, 10:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2017, 10:05 PM
Josve05a added projects: Regression, iOS-app-Bugs.Jul 22 2017, 10:50 AM
• JMinor triaged this task as Medium priority.Jul 24 2017, 7:19 PM
• JMinor added a project: iOS-app-v5.6.1-Goat-On-A-Plane.
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 1 2017, 4:27 PM
Mhurd claimed this task.Aug 7 2017, 7:15 PM
• NHarateh_WMF set the point value for this task to 1.Aug 8 2017, 7:18 PM
• NHarateh_WMF edited projects, added iOS-app-v5.7.0-Corgi-On-A-Surfboard; removed iOS-app-v5.6.1-Goat-On-A-Plane.Aug 29 2017, 6:07 PM
• JMinor lowered the priority of this task from Medium to Low.Aug 29 2017, 6:08 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 29 2017, 6:42 PM
• JMinor moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.
Mhurd moved this task from Needs Engineering Sync to Doing on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 30 2017, 9:39 PM
Mhurd added a comment.Aug 30 2017, 9:41 PM

Ok we *are* calling the logout API when user taps 'log out' so that's good...

Mhurd added a comment.Aug 30 2017, 10:03 PM

So triggering a sim memory warning to call the logout API (without clearing app cookies) does seem to put the app into a state were it shows you are logged in but edits are unattributed. Investigating fixes...

Mhurd added a comment.Aug 31 2017, 12:50 AM

https://github.com/wikimedia/wikipedia-ios/pull/1771

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 31 2017, 12:51 AM
JoeWalsh mentioned this in rAPIOSfc9d49832a54: Merge branch 'develop' into fix/edit-login-issue/T171353.Aug 31 2017, 4:54 PM
JoeWalsh mentioned this in rAPIOS05c4662671f5: Merge pull request #1771 from wikimedia/fix/edit-login-issue/T171353.
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 31 2017, 4:56 PM
Mhurd moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Aug 31 2017, 7:09 PM
• JMinor closed this task as Resolved.Oct 30 2017, 9:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL