Page MenuHomePhabricator

Do we need to add handling for the 2 silverpop mails that would not retrieve properly
Closed, ResolvedPublic2 Estimated Story Points

Description

This is a follow up to getting mailing retrieval going. There were 2 mailings retrieved by getMailings that 'didn't exist' - causing the script to fail. I worked around it by fetching mailings either side. Only 2 in 450 days but not sure if it will happen again.

eg. 52835553 - these caused the script to crash & I got around it by just skipping a time portion.

Event Timeline

Change 368940 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Make mailing get process skip on exception.

https://gerrit.wikimedia.org/r/368940

Change 368940 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Make mailing get process skip on exception.

https://gerrit.wikimedia.org/r/368940

I just re-ran this over the problem days & it completed without falling over