Page MenuHomePhabricator

VisualEditor support for Metrolook
Open, LowPublic

Description

VisualEditor does not currently support the Metrolook skin (https://www.mediawiki.org/wiki/Skin:Metrolook). It would be nice if that could be integrated.

By "does not currently support" I mean that after setting $wgVisualEditorSupportedSkins to Metrolook, the default skin to Metrolook and enabling VisualEditor on a wiki, it does not work (i.e. there is no VisualEditor option when trying to edit a page).

Version: REL1_28 (1.28.2)

Event Timeline

Deskana moved this task from To Triage to Freezer on the VisualEditor board.

@Reception123: Can you please explain what "does not currently support" exactly mean? How to reproduce coming to your conclusion? When to call this task fixed?

@Aklapper Sorry that I didn't clarify.

By "does not currently support" I mean that after setting $wgVisualEditorSupportedSkins to Metrolook, the default skin to Metrolook and enabling VisualEditor on a wiki, it does not work (i.e. there is no VisualEditor option when trying to edit a page).

matmarex subscribed.

See https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements about how to get VisualEditor to work with your skin. If you follow these steps and it still doesn't work, feel free to poke VisualEditor folks for help.

I believe I was having the same issue that this person is reporting and I fixed it with: https://www.mediawiki.org/wiki/Topic:Vk4b9hbr6drvjysg

With VE being made part of MW core, it seems to me that Metrolook MUST become VE compatible. Can anyone provide an update to this task regarding Metrolook's compatebility with MW 1.35 and offer any advice for MW 1.34 users with VE installed? Thanks!

With VE being made part of MW core

AIUI this is the long-term plan/vision, at least in some form; I assume the Parsoid people would know specifics? But VE is not yet a part of core, though it...might be bundled with the tarball release.

Can anyone provide an update to this task regarding Metrolook's compatebility with MW 1.35

Given that VE was written to initially largely support Vector and Metrolook is a fork of (an older version of) Vector (legacy skin), I'd assume that it should Just Work™. Granted, Vector has recently changed quite a bit as a part of the #desktop_improvements initiative, but I believe that's mostly impacting MW 1.36+, not 1.35.

Assuming the requirements on the page that @matmarex mentioned above are still correct (the page hasn't received any meaningful edits since 2018), Metrolook already fulfills the three must-have requirements (#content, #mw-content-text and #ca-edit).

It does not mean that fixes like https://www.mediawiki.org/wiki/Topic:Vk4b9hbr6drvjysg wouldn't be needed, but integrating such fixes into Metrolook does require some testing, and, obviously, a test environment with both the skin and VE installed.

and offer any advice for MW 1.34 users with VE installed?

Yes: update to 1.35, 1.34 is now at its end-of-life. (per mw:Version lifecycle)