Page MenuHomePhabricator

[BUG] Image background for transparent images in dark mode is an unexpected color
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. Enable dark mode
  2. View the "In the news" card for Saturday, July 23 (or any card with an image that has a transparent background)

Expected results

White background

Simulator Screen Shot Jul 24, 2017, 2.12.02 PM.png (1×750 px, 259 KB)

Actual results

Dark background

Simulator Screen Shot Jul 24, 2017, 2.12.43 PM.png (1×750 px, 260 KB)

Expected:

Regression?

Yes, previously not an issue with only light backgrounds

Event Timeline

@JoeWalsh

Guessing we'll need to leave image background views white. Images which are transparent assume white backgrounds generally. iirc this is how the theme transform deals with this... @Niedzielski can confirm? Image dimming will then dial back bright whites which come as part of images or as part of transparency.

Image backgrounds are set to white when they and their ancestors do not specify an inline background style. The reason is that many math formulas, for example, were drawn with the expectation of being shown on a light background. The heuristic is very crude so if you have a better idea, please let us know!

JMinor triaged this task as Medium priority.Jul 24 2017, 7:14 PM
JMinor subscribed.

Yes, transparent images should shown with a white background for all themes for now.

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1185). This is fixed as it shows the white background.

T171503.PNG (1×750 px, 374 KB)

ABorbaWMF subscribed.

Tested on iPhone 7+ with iOS 10.3, iPhone 4 with iOS 9.3, and iPad Pro with iOS 10.3 on Beta App version 5.6.0 (1185)

Fixed