Page MenuHomePhabricator
Create Task
Maniphest T171518

Recentchanges number of changes preference should have an upper limit
Closed, ResolvedPublic
Actions

Description

  1. On 'Preferences - Recent changes' change the "Number of edits to show in recent changes, page histories..." to really big number.
  2. The 'Save' page button can be clicked and no warning is displayed to a user. The number above the limit will be displayed as saved.

Screen Shot 2017-07-24 at 12.36.21 PM.png (723×758 px, 148 KB)

Note:

  1. The RC setting "Days to show in recent changes" will display the warning:

Screen Shot 2017-07-24 at 12.38.07 PM.png (432×754 px, 183 KB)

  1. 'Preferences -Watchlist' will display the warning (as above) for both 'Display options': "Days to show in watchlist" and "Maximum number of changes to show in expanded watchlist".
  1. On RC page the max limit for ""Number of edits to show in recent changes..." - 5,000 will be displayed.

Related Objects

Event Timeline

Etonkovidova created this task.Jul 24 2017, 7:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2017, 7:51 PM
Etonkovidova renamed this task from [minor] Preferences-Recent changes "Number of edits to show in recent changes, page histories..." allows to save a number bigger than the limit to [minor] Preferences-Recent changes "Number of edits to show in recent changes, page histories..." option allows to save a number bigger than the limit.Jul 24 2017, 7:52 PM
Catrope subscribed.Aug 1 2017, 5:55 PM

There is no limit right now. Per T172026#3483291 there should be one.

Catrope renamed this task from [minor] Preferences-Recent changes "Number of edits to show in recent changes, page histories..." option allows to save a number bigger than the limit to Recentchanges number of changes preference should have an upper limit.Aug 1 2017, 5:56 PM
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Let's limit it to 1000 for now, (and 500 later once we have pagination), for consistency with the watchlist limit.

Catrope moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Oct 10 2017, 6:23 PM

There is now an upper limit of 1000.

Etonkovidova added a comment.Oct 10 2017, 7:21 PM

Checked in 1.31.0-wmf.2 - the issue is fixed. The proper warning is displayed when a user attempts to save the bigger number than 1,000 for "Number of edits to show in recent changes, page histories..."

Screen Shot 2017-10-10 at 11.53.50 AM.png (190×502 px, 42 KB)

Etonkovidova closed this task as Resolved.Oct 10 2017, 7:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits