Page MenuHomePhabricator
Create Task
Maniphest T171560

Strict error message in logs (quick tidy up)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

PHP Strict Standards: Only variables should be passed by reference in /srv/www/org/wikimedia/listeners/SmashPig/Maintenance/MaintenanceBase.php on line 153

Details

SubjectRepoBranchLines +/-
Fix 'Only variables should be passed by reference'wikimedia/fundraising/SmashPigmaster+3 -1
Get rid of return-a-reference optionwikimedia/fundraising/SmashPigmaster+15 -30
Get rid of return-a-reference optionwikimedia/fundraising/SmashPigdeployment+15 -30
Customize query in gerrit

Event Timeline

Eileenmcnaughton created this task.Jul 25 2017, 1:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2017, 1:43 AM
• DStrine triaged this task as Medium priority.Jul 25 2017, 7:36 PM
• DStrine set the point value for this task to 1.
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
gerritbot subscribed.Jul 25 2017, 8:13 PM

Change 367747 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@deployment] Get rid of return-a-reference option

https://gerrit.wikimedia.org/r/367747

gerritbot added a project: Patch-For-Review.Jul 25 2017, 8:13 PM

Change 367748 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Get rid of return-a-reference option

https://gerrit.wikimedia.org/r/367748

gerritbot added a comment.Jul 25 2017, 10:24 PM

Change 367747 abandoned by Ejegg:
Get rid of return-a-reference option

Reason:
oops, wrong branch

https://gerrit.wikimedia.org/r/367747

Ejegg claimed this task.Aug 1 2017, 8:21 PM
Ejegg added a project: Fundraising Sprint Navel Warfare.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Navel Warfare board.
gerritbot added a comment.Aug 1 2017, 10:17 PM

Change 367748 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Get rid of return-a-reference option

https://gerrit.wikimedia.org/r/367748

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Navel Warfare board.Aug 1 2017, 10:20 PM
• DStrine moved this task from Sprint +1 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Aug 2 2017, 6:22 PM
• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Outie Inverter board.Aug 2 2017, 8:40 PM
Ejegg moved this task from Pending Deployment to Review on the Fundraising Sprint Outie Inverter board.Aug 2 2017, 10:00 PM
gerritbot added a comment.Aug 2 2017, 10:01 PM

Change 369803 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Fix 'Only variables should be passed by reference'

https://gerrit.wikimedia.org/r/369803

gerritbot added a comment.Aug 7 2017, 2:33 PM

Change 369803 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Fix 'Only variables should be passed by reference'

https://gerrit.wikimedia.org/r/369803

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Outie Inverter board.Aug 9 2017, 3:40 PM
• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Outie Inverter board.Aug 17 2017, 4:44 PM
Ejegg closed this task as Resolved.Aug 17 2017, 4:51 PM
• DStrine moved this task from Backlog to Done on the Fundraising Sprint Prank Seatbelt board.Oct 18 2017, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL