Don't float article actions on tablets
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	• Nirzar
	Jul 25 2017, 4:13 PM

Description

Problem

Currently we float language, watchstar, and edit icons on tablets in Minerva. there is no need to float them, we can persist the article toolbar like we have on mobile.

Why

It will give us an anchor to title and the layout. it will also give us ability to add more actions in the future instead of floating. floating was appropriate when there wwas only one action

Mocks

Developer notes

This can be just done by stripping the extra responsive css

Actions are not floated on tablets
No change on small screens

Details

	Subject	Repo	Branch	Lines +/-
	Remove first heading padding	mediawiki/skins/MinervaNeue	master	+0 -4
	Don't float article actions on tablets	mediawiki/skins/MinervaNeue	master	+0 -37

Customize query in gerrit

Related Objects

Mentioned In: T169126: Page actions bar broken in IE11

Event Timeline

• Nirzar created this task.Jul 25 2017, 4:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2017, 4:13 PM

• Nirzar moved this task from Backlog to Visual Design Improvements on the Design (RW-Design-Debt) board.Jul 25 2017, 4:14 PM

Jdlrobson updated the task description. (Show Details)Jul 25 2017, 5:29 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

• Nirzar added a project: MinervaNeue (Desktop).Jul 25 2017, 9:22 PM

ovasileva triaged this task as Medium priority.Aug 2 2017, 2:08 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Aug 2 2017, 8:41 PM

Jdlrobson updated the task description. (Show Details)Aug 8 2017, 4:35 PM

Jdlrobson set the point value for this task to 3.Aug 8 2017, 4:43 PM

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Aug 9 2017, 1:47 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Aug 9 2017, 5:50 PM

ovasileva moved this task from Needs Design Review to To Do on the Readers-Web-Kanbanana-Board-Old board.Aug 9 2017, 5:51 PM

• bmansurov claimed this task.Aug 14 2017, 4:27 PM

• bmansurov moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 371953 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/skins/MinervaNeue@master] Don't float article actions on tablets

https://gerrit.wikimedia.org/r/371953

gerritbot added a project: Patch-For-Review.Aug 14 2017, 4:44 PM

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 14 2017, 4:44 PM

I've merged the patch.
There's one additional rule we might also be able to remove for tablets:

.heading-holder h1 {
    padding-right: 16px;
}

I'm not sure but I'm moved this to needs more work until we can dismiss/confirm.

Change 371953 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Don't float article actions on tablets

https://gerrit.wikimedia.org/r/371953

• bmansurov moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Aug 16 2017, 3:52 PM

Change 372161 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/skins/MinervaNeue@master] Remove first heading padding

https://gerrit.wikimedia.org/r/372161

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 16 2017, 3:58 PM

@Nirzar there's a padding to the right of heading in mobile, I'm removing it as part of this task. Is that OK?

Screenshot from 2017-08-16 12-03-36.png (203×744 px, 15 KB)

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Aug 16 2017, 5:01 PM

Change 372161 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove first heading padding

https://gerrit.wikimedia.org/r/372161

• bmansurov removed • bmansurov as the assignee of this task.Aug 16 2017, 5:06 PM

• bmansurov subscribed.

Macro votecat: looks good

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 6:02 PM

Jdlrobson mentioned this in T169126: Page actions bar broken in IE11.Oct 16 2017, 10:33 PM

	F9089554: Screenshot from 2017-08-16 12-03-36.png
	Aug 16 2017, 4:04 PM

Don't float article actions on tabletsClosed, ResolvedPublic3 Estimated Story PointsActions