Clean up skin properties
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	• demon
	Jul 25 2017, 7:27 PM

Description

This is probably one of the bigger offenders with the parent task. Take, for example the enwiki preference

P5802 enwiki skin distribution

1	mysql> select up_value as skin, count(*) as cnt from user_properties where up_property = 'skin' group by up_value order by cnt desc; ------+---------+ \| cnt \| ------+---------+ \| 7179793 \| \| 2190692 \| \| 162396 \| 86829 \| \| 80839 \| \| 53975 \| \| 34178 \| \| 31859 \| \| 21142 \| \| 16177 \| \| 14113 \| \| 3056 \| \| 1754 \| \| 1290 \| \| 105 \| 27 \| 8 \| -------+---------+ rows in set (1 min 36.25 sec)

The only valid values here are monobook, vector, cologneblue, modern and the various minervas (which should be merged, see T171644: Clarify minerva preference name).

After solving the subtask, we could run the following query on all wikis:

DELETE FROM user_properties WHERE up_property = 'skin' AND up_value NOT IN ('vector', 'monobook', 'minervaneue', 'minerva', 'timeless', 'modern', 'cologneblue', '0', '2');

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Resolved	KStoller-WMF	T347840 [Epic] Q2 FY 2023-24 Growth Maintenance Work
Open	None	T54777 user_properties table bloat
Duplicate	None	T171643 Clean up skin properties
Resolved	Jdlrobson	T171644 Clarify minerva preference name
Resolved	Krinkle	T173546 ResourceModuleSkinStyles does not resolve skin aliases

Event Timeline

• demon created this task.Jul 25 2017, 7:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2017, 7:27 PM

• demon created subtask T171644: Clarify minerva preference name.Jul 25 2017, 7:28 PM

Jdforrester-WMF updated the task description. (Show Details)Jul 25 2017, 7:35 PM

Jdforrester-WMF subscribed.

The only valid values here are monobook, vector, cologneblue, modern and the various minervas (which should be merged, see T171644: Clarify minerva preference name).

That's not true. '0' and '2' are also valid values, mapped to Vector and CologneBlue by Skin::normalizeKey().

In T171643#3472259, @matmarex wrote:

The only valid values here are monobook, vector, cologneblue, modern and the various minervas (which should be merged, see T171644: Clarify minerva preference name).

That's not true. '0' and '2' are also valid values, mapped to Vector and CologneBlue by Skin::normalizeKey().

0 maps to Vector by legacy happy accident. It used to map to Monobook. It basically means use the default and can be cleaned up.

Fair point about 2. Tbh I had thought I jettisoned this behavior some time ago

After solving the subtask, we could run the following query on all wikis:

I would prefer if this gets run by a maintenance script using mediawiki, we normally do not touch data directly on the databases as it can be dangerous and create inconsistencies.

Marostegui moved this task from Triage to Blocked external/Not db team on the DBA board.Jul 31 2017, 7:59 AM

In T171643#3485107, @Marostegui wrote:

After solving the subtask, we could run the following query on all wikis:

I would prefer if this gets run by a maintenance script using mediawiki, we normally do not touch data directly on the databases as it can be dangerous and create inconsistencies.

I'm already working on said script, but the logic is the same :)

Jdlrobson closed subtask T171644: Clarify minerva preference name as Resolved.Oct 18 2017, 11:04 PM

• demon mentioned this in T54777: user_properties table bloat.Jan 30 2018, 6:03 PM

P6653 Results of skin-not-in ('vector', 'monobook', 'minervaneue', 'minerva', 'timeless', 'modern', 'cologneblue')

1	arwiki
2	bgwiki
3	bnwiki
4	bswiki
5	cawiki
6	cebwiki
7	commonswiki
8	cswiki
9	dawiki
10	dewiki
11	dewiktionary
12	elwiki
13	enwiki
14	enwikibooks
15	enwikinews
16	enwikiquote
17	enwikisource
18	enwikiversity
19	enwiktionary
20	eowiki
21	eswiki
22	etwiki
23	fawiki
24	fiwiki
25	frwiki
26	frwikisource
27	frwiktionary
28	hewiki
29	huwiki
30	iawiki
31	idwiki
32	incubatorwiki
33	iswiki
34	itwiki
35	kowiki
36	labswiki
37	metawiki
38	mgwiktionary
39	mkwiki
40	mswiki
41	nlwiki
42	nowiki
43	plwiki
44	ptwiki
45	rowiki
46	shwiki
47	simplewiki
48	sourceswiki
49	srwiki
50	svwiki
51	tawiki
52	trwiki
53	trwiktionary
54	ukwiki
55	urwiki
56	viwiki
57	warwiki
58	wikidatawiki
59	yiwiki
60	zhwiki
61	zhwiktionary

@demon Just to remind, that query is wrong, especially if you plan to use the same condition for deleting:

In T171643#3472259, @matmarex wrote:

The only valid values here are monobook, vector, cologneblue, modern and the various minervas (which should be merged, see T171644: Clarify minerva preference name).

That's not true. '0' and '2' are also valid values, mapped to Vector and CologneBlue by Skin::normalizeKey().

matmarex updated the task description. (Show Details)Feb 1 2018, 10:32 PM

I'm not planning to run any queries. I was just digging at some data.

• Elitre subscribed.Feb 2 2018, 12:39 PM

Quiddity subscribed.Apr 5 2018, 5:05 PM

Marostegui removed a project: DBA.Aug 7 2018, 12:27 PM

Just to be sure I understand correctly what should be done to resolve this task. A new maintenance script should be created that removes the empty and 0 keys (their meaning is using the default skin which is the same as not having an entry in the table), updates the keys with the value 2 to cologneblue and deletes all the keys not in Skin::getSkinNames() (this way it should work too for 3rd parties with different skins installed than the ones in Wikimedia wikis).

Should it delete also the keys that match with the default skin or should it left them as is?

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 14 2020, 3:19 PM

DannyS712 subscribed.Jan 14 2020, 5:00 PM

• Elitre unsubscribed.Jan 21 2020, 6:48 PM

Krinkle mentioned this in T305966: Users who have selected legacy Vector, seeing Vector 2022 on certain page views.Apr 13 2022, 11:40 PM

Krinkle mentioned this in T306056: Investigate why skin preference is set to empty string for various users.

Ladsgroup subscribed.Apr 14 2022, 7:44 PM

Pppery closed this task as a duplicate of T54778: Clean up skin user preferences in user_properties table on Wikimedia wikis.Jun 22 2023, 12:46 AM