Maniphest T171658

Populate country column when creating c_t rows during offline import
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ejegg
	Jul 25 2017, 8:53 PM

Referenced Files

None

Subscribers

Description

When we create contribution_tracking rows for donations imported via spreadsheet, we should populate the country column when we know it.

Details

	Subject	Repo	Branch	Lines +/-
	Fix c_t.country population, add test	wikimedia/fundraising/crm	master	+41 -1
	Add country to c_t rows created during imports	wikimedia/fundraising/crm	master	+6 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		Ejegg	T171658 Populate country column when creating c_t rows during offline import

Event Timeline

Ejegg created this task.Jul 25 2017, 8:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2017, 8:53 PM

Change 367806 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Add country to c_t rows created during imports

https://gerrit.wikimedia.org/r/367806

gerritbot added a project: Patch-For-Review.Jul 25 2017, 9:22 PM

Pcoombe added a parent task: Restricted Task.Jul 26 2017, 9:31 AM

Ejegg claimed this task.Jul 28 2017, 7:56 PM

Ejegg triaged this task as Low priority.

Ejegg added a project: Fundraising Sprint Navel Warfare.

Ejegg set the point value for this task to 1.

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Navel Warfare board.

Change 367806 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add country to c_t rows created during imports

https://gerrit.wikimedia.org/r/367806

• DStrine moved this task from Triage to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Jul 31 2017, 10:06 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Navel Warfare board.Aug 1 2017, 4:48 PM

• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Outie Inverter board.Aug 2 2017, 8:40 PM

• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Prank Seatbelt board.Aug 17 2017, 7:47 PM

Huh, recent Benevity imports still have null country in c_t. Taking another look.

Change 374597 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP fix c_t.country population, add test

https://gerrit.wikimedia.org/r/374597

Ejegg moved this task from Doing to Review on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 8:01 PM

Change 374597 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Fix c_t.country population, add test

https://gerrit.wikimedia.org/r/374597

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.Aug 30 2017, 8:02 PM

• DStrine added a project: Fundraising Sprint Quill Pencil.Aug 30 2017, 8:21 PM

Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint Quill Pencil board.Aug 31 2017, 6:04 AM

Ejegg moved this task from Review to Done on the Fundraising Sprint Quill Pencil board.Aug 31 2017, 3:27 PM

• DStrine added a project: Fundraising Sprint RadioActivewear.Sep 13 2017, 8:28 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint RadioActivewear board.Sep 13 2017, 10:35 PM

Still waiting for non-check imports to test this one. For historical reasons, we're still not creating contribution_tracking records for checks.

• DStrine added a project: Fundraising Sprint Synchronized Screaming.Sep 26 2017, 8:46 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Synchronized Screaming board.Sep 26 2017, 9:15 PM

• DStrine added a project: Fundraising Sprint turtles that are robotic that destroy the whole world with their foot.Oct 10 2017, 8:30 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.Oct 10 2017, 9:45 PM

• DStrine moved this task from Current Sprint and Completed in Q1 2017-18 to Completed in Q2 2017-18 on the Fundraising-Backlog board.Oct 20 2017, 5:41 PM

• DStrine added a project: Fundraising Sprint Uptight Piano.Oct 24 2017, 8:21 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Uptight Piano board.Oct 25 2017, 11:40 PM

Finally some rows to check this against! Seems to be working.