Page MenuHomePhabricator

Remove MapCacheLRU in favor of HashBagOStuff
Closed, ResolvedPublic

Description

It seems all cases for MapCacheLRU can be solved with HashBagOStuff; they both have LRU-based expiration. It makes more sense to keep HashBagOStuff, since it also has time-based expiration and subclasses BagOStuff.

Event Timeline

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.
Krinkle moved this task from Unsorted to Needs removal on the Technical-Debt board.
Krinkle claimed this task.
Krinkle added a project: Performance-Team.
Krinkle added subscribers: aaron, Krinkle.

At the time this task was created, we also had ProcessCacheLRU which is similar to MapCacheLRU. It was thought that ProcessCacheLRU is worth keeping because it supports sub-fields.

Over the past week, @aaron has ported that logic into MapCacheLRU and deprecated ProcessCacheLRU, which effectively resolves the issue.