Page MenuHomePhabricator
Create Task
Maniphest T171728

Linear selection can partially span a table (regression)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This should not be possible as it allows strange deletions to happen

image.png (152×136 px, 6 KB)

image.png (137×121 px, 3 KB)

Bisect blames this commit: https://gerrit.wikimedia.org/r/#/c/345955/

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (f444fa19b)mediawiki/extensions/VisualEditormaster+1 -1
Default table cells to ce=false, and always set ce state to editing stateVisualEditor/VisualEditormaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 26 2017, 12:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2017, 12:36 PM
gerritbot subscribed.Jul 26 2017, 1:27 PM

Change 367890 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Default table cells to ce=false, and always set ce state to editing state

https://gerrit.wikimedia.org/r/367890

gerritbot added a project: Patch-For-Review.Jul 26 2017, 1:27 PM
• Deskana triaged this task as High priority.Jul 26 2017, 1:30 PM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Jul 26 2017, 3:27 PM

Change 367890 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Default table cells to ce=false, and always set ce state to editing state

https://gerrit.wikimedia.org/r/367890

gerritbot added a comment.Jul 26 2017, 11:55 PM

Change 367840 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f444fa19b)

https://gerrit.wikimedia.org/r/367840

• Deskana closed this task as Resolved.Jul 31 2017, 5:36 PM
• Deskana assigned this task to Esanders.
• Deskana set the point value for this task to 1.
• Deskana removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 31 2017, 5:36 PM
gerritbot added a comment.Jul 31 2017, 5:42 PM

Change 367840 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f444fa19b)

https://gerrit.wikimedia.org/r/367840

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 31 2017, 6:00 PM
Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Aug 3 2017, 11:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL