Maniphest T171799

Pages not adhering to dark mode
Closed, ResolvedPublic
Actions

Assigned To

• NHarateh_WMF

Authored By

	Josve05a
	Jul 26 2017, 10:40 PM

Tags

Referenced Files

	F9143170: T171799 Languages Default.PNG
	Aug 21 2017, 9:46 PM

	F9143172: T171799 About Default.PNG
	Aug 21 2017, 9:46 PM

	F9143169: T171799 Languages Dark.PNG
	Aug 21 2017, 9:46 PM

	F9143171: T171799 About Dark.PNG
	Aug 21 2017, 9:46 PM

	F8944037: 20641935_1676369209060386_1170007621_o.jpg
	Aug 4 2017, 4:47 AM

	F8944039: 20629892_1676369205727053_372732709_o.jpg
	Aug 4 2017, 4:47 AM

Subscribers

Description

The following pages do not adhear to the set darkmode (i.e. it is still white):

About the app page
Libraries used page

5.6.0 (1182)
iPhone 6s
iOS 11 beta 4

Settings → My languages	Search → My languages

5.6.0 (1189)
iPhone 6s
iOS 11 beta 4

Related Objects

Mentioned In: T178214: [BUG] The "My languages" page still does not fully adhear to dark mode

Event Timeline

Josve05a created this task.Jul 26 2017, 10:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2017, 10:40 PM

Josve05a updated the task description. (Show Details)Jul 26 2017, 10:40 PM

Josve05a moved this task from Backlog to iOS App on the User-Josve05a board.Jul 26 2017, 10:58 PM

Josve05a updated the task description. (Show Details)Aug 4 2017, 4:47 AM

Josve05a updated the task description. (Show Details)

• JMinor triaged this task as Low priority.Aug 14 2017, 8:01 PM

• JMinor added a project: iOS-app-v5.6.1-Goat-On-A-Plane.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 14 2017, 8:04 PM

• NHarateh_WMF claimed this task.Aug 15 2017, 4:42 PM

• NHarateh_WMF moved this task from Ready for Development to Doing on the iOS-app-v5.6.1-Goat-On-A-Plane board.

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 16 2017, 11:07 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 21 2017, 4:12 PM

JoeWalsh moved this task from Waiting for Build to Needs QA on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 21 2017, 5:59 PM

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.1 (1200). This is fixed according to the screencaps below, default mode and dark mode work for about and language screens.

T171799 About Default.PNG (1×750 px, 189 KB)

T171799 About Dark.PNG (1×750 px, 192 KB)

T171799 Languages Default.PNG (1×750 px, 58 KB)

T171799 Languages Dark.PNG (1×750 px, 59 KB)

• NHarateh_WMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 21 2017, 10:06 PM

• JMinor closed this task as Resolved.Aug 30 2017, 9:47 PM

Josve05a mentioned this in T178214: [BUG] The "My languages" page still does not fully adhear to dark mode.Oct 14 2017, 12:46 AM