Page MenuHomePhabricator
Create Task
Maniphest T171808

Insert button on Code Editor and Save page gets enabled after selecting a language and when nothing really has been added
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open Code Editor
  2. Select a language
  3. Without typing in anything in the editor, click on the Insert button
  4. Observe the "Save page" button also got enabled on the page
  5. If you now look at the diff view, you will see there have been no changes but still, you will be able to save the page.

This bug seems to exist in production too, but I see one tiny difference in the way it shows in wikitext view. In Beta and test2 it just says "no changes" but in en.wiki it shows an empty line has been added.

Diff view in test2 and Beta:

Screen Shot 2017-07-26 at 5.53.29 PM.png (680×1 px, 196 KB)

Diff view in en.wiki:

Screen Shot 2017-07-26 at 5.54.11 PM.png (639×1 px, 145 KB)

Event Timeline

Ryasmeen created this task.Jul 27 2017, 12:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2017, 12:56 AM
• Deskana added a comment.Jul 28 2017, 10:49 AM

@Ryasmeen I can't reproduce this. When I click insert, the save page button isn't enabled. Are there some steps missing, or can you no longer reproduce as well?

Ryasmeen closed this task as Resolved.Jul 29 2017, 12:12 AM

@Deskana, hmm I can't reproduce it either. Closing it for now.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 29 2017, 12:12 AM
• Deskana set the point value for this task to 0.Jul 29 2017, 12:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL