With all the json encoding and decoding, 1234.0 often gets rounded off to just 1234
So if our payments front end sends a message with order id 1234.0 and the IPN sends a message with order ID 1234, we end up recording the same contribution twice.
We need to start the sequence numbers at .1 and find any duplicates already recorded
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Order sequence numbers start at 1, not 0 | mediawiki/extensions/DonationInterface | master | +53 -44 |
Change 368266 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP order sequence numbers start at 1, not 0
Change 368266 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Order sequence numbers start at 1, not 0
Good news: there aren't any duplicate PayPal EC donations - we're using the actual alphanumeric PayPal transaction id to identify those, not our compound order ID. This ticket was still a good idea, though.