Page MenuHomePhabricator

[minor] RC page - a filter's name that spans several lines needs vertical adjustment
Closed, ResolvedPublic

Description

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2017, 8:45 PM
Etonkovidova renamed this task from [minor] RC page - a filter's name that spans several line needs vertical adjustment to [minor] RC page - a filter's name that spans several lines needs vertical adjustment.Jul 27 2017, 9:57 PM

Putting a limit in is a good idea. I can think of two approaches:

  1. We truncate the titles in the Saved filters menus. But we currently let this run to full length, even if it wraps (I checked). So we could decide to truncate this at one line, which should be more than enough.
  2. Or, we can keep the title line tidy by setting the limit at a long but reasonable limit. 99 characters would provide room for a very long and detailed name, even in German, but would stop about halfway across the line on a typical browser setting.

I don't have a preference here. I can imagine some very intensive user who'd want to actually list some of the filters that make up the setting. But such a reviewer would be an extreme outlier. So whoever picks this up can decide between these choices. You might pick whichever is easier.

Catrope added subscribers: Pginer-WMF, Catrope.

@Pginer-WMF Thoughts for how to handle this?

Roan says truncating line to 1-line width is the preferred solution.

@Pginer-WMF Thoughts for how to handle this?

In this context we display a name of user created content, so even if shown partially is likely the user knows what it is about.
Keeping it one-line as @jmatazzoni suggested should work well.

Change 373158 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Truncate long saved query titles

https://gerrit.wikimedia.org/r/373158

This is not on the blockers list, FYI.

Change 373158 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Truncate long saved query titles

https://gerrit.wikimedia.org/r/373158

Etonkovidova added a comment.EditedAug 25 2017, 5:57 PM

Checked in betalabs (the length of the displayed string is truncated to 150 characters):

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.Aug 25 2017, 6:41 PM