Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
RCFilters: Truncate long saved query titles | mediawiki/core | master | +4 -0 |
Event Timeline
Putting a limit in is a good idea. I can think of two approaches:
- We truncate the titles in the Saved filters menus. But we currently let this run to full length, even if it wraps (I checked). So we could decide to truncate this at one line, which should be more than enough.
- Or, we can keep the title line tidy by setting the limit at a long but reasonable limit. 99 characters would provide room for a very long and detailed name, even in German, but would stop about halfway across the line on a typical browser setting.
I don't have a preference here. I can imagine some very intensive user who'd want to actually list some of the filters that make up the setting. But such a reviewer would be an extreme outlier. So whoever picks this up can decide between these choices. You might pick whichever is easier.
In this context we display a name of user created content, so even if shown partially is likely the user knows what it is about.
Keeping it one-line as @jmatazzoni suggested should work well.
Change 373158 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Truncate long saved query titles
Change 373158 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Truncate long saved query titles
Checked in betalabs (the length of the displayed string is truncated to 150 characters):
QA Recommendation: Resolve