Visual diff broken for revision deletions
Open, NormalPublic1 Story Points

Description

Steps to reproduce:

  1. Visit a diff which has been deleted, eg. https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Benutzer:Schnark&diff=2074&oldid=1945&visualdiff=1
  2. Switch to visual diff.
  3. If you have the right to view the deleted diff, do so.
  4. Switch to visual diff again.

Actual result:
The visual diff fails to load in both cases, and just shows the loading bar.

Expected result:
When you are not allowed to view the diff, the switch widget should either don't exist at all, be disabled, or don't do anything except telling you that you can't view the diff.
I don't know whether it is possible to show visual diffs for deleted revisions you have the right to view. If it is possible, then the diff should be shown, if RESTbase isn't able to do so, the switcher should be disabled for such diffs.

Schnark created this task.Jul 28 2017, 8:56 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 28 2017, 8:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana triaged this task as Normal priority.Jul 28 2017, 2:13 PM
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Deskana set the point value for this task to 1.Aug 22 2017, 2:24 PM