Maniphest T171939

[BUG] 'download in progress' icon showing on an article that is already saved for offline
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jul 28 2017, 9:41 AM

Description

Steps to reproduce

Open an article (eg John McCain)
Add that article to a reading list
Go into airplane mode
Tap on a link to another article (Eg "US Navy") within that first article
Tap to add the second article to the same reading list
Tap to go to the reading list where both articles have been saved, then exit airplane mode
Exit airplane mode

Expected

The second article should have been made 'available for offline' only after the app went back online (step 8)

Actual

The 'download in progress' icon is shown against both articles when only the second article added to the list via the link preview was not yet downloaded.
The 'download in progress' icon remains even after opening both articles when online.

See video showing this at:
https://youtu.be/CT3g_1Vaw58

NOTE: A similar bug exists in the prod version 2.5.198-r-2017-06-09, but since there is no 'download in progress' icon, the metadata is instead showing "2 out of 2 articles available offline" even though it is not the case.

Can we incorporate more tests scenarios for adding articles to read offline? eg this current one, and T166383.

Occurring on

Device = Nexus 5 (Android 6.0.1)
Version = 2.6.198-alpha-2017-07-27

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix saving pages for offline use (convincingly).	apps/android/wikipedia	master	+13 -7
	Improve (fix?) loading updating of pages for offline use.	apps/android/wikipedia	master	+132 -81

Customize query in gerrit

Related Objects

Mentioned Here: T166383: [BUG] Article is not downloaded for offline if user goes offline before the activity is complete

Event Timeline

RHo created this task.Jul 28 2017, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2017, 9:41 AM

RHo renamed this task from [BUG] to [BUG] 'download in progress' icon showing on an article that is already saved for offline.Jul 28 2017, 9:42 AM

RHo updated the task description. (Show Details)Jul 28 2017, 10:05 AM

Cannot reproduce...

Hmm I updated step 6 to reproduce to reflect that you go to view list before exiting airplane mode and am able to reproduce.

Seeing it on Wikipedia version 2.6.168-alpha-2017-07-28 on the same Nexus 5 (Android 6.0.1) device:
https://youtu.be/2wJ4tYcEvrs

On Pixel (Android 7.1.2), there is similar erratic behavior in the display of the offline downloading icon:
https://youtu.be/00jhIAVIDnA

RHo updated the task description. (Show Details)Jul 28 2017, 2:18 PM

Change 368488 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Improve (fix?) loading updating of pages for offline use.

https://gerrit.wikimedia.org/r/368488

gerritbot added a project: Patch-For-Review.Jul 28 2017, 8:20 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.20x-Dookie💩 on the Wikipedia-Android-App-Backlog board.Jul 28 2017, 9:29 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩). · View Herald TranscriptJul 28 2017, 9:29 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.20x-Dookie💩 on the Wikipedia-Android-App-Backlog board.Jul 28 2017, 9:29 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.

Change 368488 merged by jenkins-bot:
[apps/android/wikipedia@master] Improve (fix?) loading updating of pages for offline use.

https://gerrit.wikimedia.org/r/368488

Dbrant claimed this task.Aug 1 2017, 2:04 PM

Dbrant moved this task from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia version 2.6.198-alpha-2017-07-27.
As shown in the 3rd capture below, the 'download in progress' icon is still shown for a minute after airplane mode
is turned off. However, it does eventually disappear after a minute and once the article is opened. Hopefully it is fixed.

• Mholloway subscribed.Aug 2 2017, 3:40 PM

FWIW Looks fixed on my Nexus 5 (6.0.1) as well.

@Dbrant - looks like a regression on v2.6.200-alpha-2017-08-09 ?
Articles that have been downloaded continue to show the 'download in progress' icon.
https://youtu.be/XrUt8JPz8GQ

@RHo It didn't really look like you were giving the articles enough time to download. What happens when you exit airplane mode, and keep looking at the reading list screen for a few more seconds?

@Dbrant - it's definitely stuck. I've been back online for the past 15min and still showing the progress icon:

main-MainActivity-08102017161350.png (1×1 px, 715 KB)

Change 371118 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix saving pages for offline use (convincingly).

https://gerrit.wikimedia.org/r/371118

Change 371118 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix saving pages for offline use (convincingly).

https://gerrit.wikimedia.org/r/371118

Dbrant moved this task from Blocked/Waiting to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 23 2017, 2:10 PM

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-25

Looks good now. Icons are appearing and disappearing as expected.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 29 2017, 12:09 PM

Dbrant closed this task as Resolved.Aug 29 2017, 12:09 PM

	F9021270: main-MainActivity-08102017161350.png
	Aug 10 2017, 2:14 PM

	F8927020: T171939 Part 2.png
	Aug 1 2017, 11:55 PM

	F8927022: T171939 Part 1.png
	Aug 1 2017, 11:55 PM

	F8927021: T171939 Part 3.png
	Aug 1 2017, 11:55 PM

[BUG] 'download in progress' icon showing on an article that is already saved for offlineClosed, ResolvedPublicActions