Maniphest T172013

Images with transparent backgrounds change color if the theme is changed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABorbaWMF
	Jul 28 2017, 9:35 PM

Project Tags

Referenced Files

	F8934706: T172013 Sepia.PNG
	Aug 2 2017, 11:27 PM

	F8934707: T172013 Dark.PNG
	Aug 2 2017, 11:27 PM

	F8887161: IMG_1529.PNG
	Jul 28 2017, 9:35 PM

	F8887158: IMG_1525.PNG
	Jul 28 2017, 9:35 PM

Subscribers

Description

Steps:

In sepia or default theme, go to an article with a lead image that has a transparent background
Change to night mode

Expected Result:
The image background remains white

Actual Result:
The image background changes to gray

Example Articles:
Two-dimensional space
Roosevelt Dime

Related Objects

Mentioned In: rAPIOSab6bcb83d424: Merge pull request #1680 from wikimedia/bug/T172013

Event Timeline

ABorbaWMF created this task.Jul 28 2017, 9:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2017, 9:35 PM

JoeWalsh claimed this task.Jul 31 2017, 2:51 PM

JoeWalsh triaged this task as Low priority.

JoeWalsh added a project: iOS-app-v5.6.0-Goat-On-A-Train.

JoeWalsh moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.6.0-Goat-On-A-Train board.

JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 31 2017, 3:03 PM

This should not change iirc. Math images (and others) which have dark line art and transparent backgrounds would appear solid black.

@Mhurd this ticket is for fixing the issue you're describing. The background currently changes to dark gray when switching to the dark theme. The fix is to always keep the background white when an image is set.

Lol I read it in reverse :)

JoeWalsh mentioned this in rAPIOSab6bcb83d424: Merge pull request #1680 from wikimedia/bug/T172013.Jul 31 2017, 5:41 PM

JoeWalsh moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.6.0-Goat-On-A-Train board.Aug 2 2017, 12:46 PM

JoeWalsh moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.6.0-Goat-On-A-Train board.

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1189). This is fixed according to the screencaps below.

T172013 Sepia.PNG (750×1,334 px, 399 KB)

Tested on iPad Pro with iOS 10.3.3 and iPhone 7+ with iOS 10.3.3 on App 5.6.0 (1189)

Roosevelt dime looks good

• JMinor closed this task as Resolved.Aug 14 2017, 7:29 PM

Images with transparent backgrounds change color if the theme is changedClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Images with transparent backgrounds change color if the theme is changed
Closed, ResolvedPublic
Actions