Page MenuHomePhabricator

[Bug] The feed appears to be jumping a bit when the notification card is added into the feed
Closed, ResolvedPublic

Description

Steps to reproduce
Fresh install of app
Scroll down on the explore feed until you reach your first news card

Expected results
User education card on notifications is presented above the news card

Actual results
The notification card is inserted as the news card is scrolled onto the screen

Example of feed 'jumping' when inserting the notification card:
http://www.usertesting.com/c/e0404039-ac9d-4dad-a425-ab0a2976cbeb?note_id=clip-1332235&shared=wVDnGoJr

Event Timeline

In this case, an older news day was loaded with a newer feed day. When the older feed content loads in, the news content moves down the feed to the correct day. We could eliminate this problem by only adding the news to the feed if the feed date matches the news date.

@JoeWalsh would this mean then that if you hadn't loaded a feed in the past few weeks, as you scrolled back in time you would no longer have news cards?

@cmadeo you would still get older news cards as you scroll back in time. Same is true for a new user scrolling back in time.

@JoeWalsh awesome, thanks for the clarification!

Hi, I think this is fixed in the environment I'm using - iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1189) - there is no jumping or weird behavior, but I don't know what a "User education card" is. Screencaps of the correct vs. incorrect results would be helpful, thanks!

ABorbaWMF subscribed.

Tested on iPad Pro with iOS 10.3.3 and iPhone 7+ with iOS 10.3.3 on App 5.6.0 (1189)

Looks good now. @Nicholas.tsg, it was the theme card (default, sepia, dark) at the top of the explore feed.