Maniphest T172021

It shouldn't be possible for coordinates to be the lead paragraph
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 28 2017, 11:27 PM

Description

http://0.0.0.0:6927/en.wikipedia.org/v1/page/preview-html/Spain is currently returning

<p><span>
</span>


<span style="font-size: small;"><span id="coordinates"><span>Coordinates</span>: <span class="plainlinks nourlexpansion"><span><span class="geo-default"><span class="geo-dms"><span class="latitude">40°N</span> <span class="longitude">4°W</span></span></span></span></span></span></span></p>

as the summary

and the http://0.0.0.0:6927/en.wikipedia.org/v1/page/formatted/Spain
sets the intro as

"intro":"<p><span>\n</span>\n\n\n<span style=\"font-size: small;\"><span id=\"coordinates\"><a href=\"./Geographic_coordinate_system\" title=\"Geographic coordinate system\">Coordinates</a>: <span class=\"plainlinks nourlexpansion\"><a rel=\"m ...

Developer notes

The main crux of the issue is that we don't scrub #coordinates from output. We should and we should rely on the GeoData api (see related T152441)

Details

	Subject	Repo	Branch	Lines +/-
	Scrub #coordinates from response	mediawiki/services/mobileapps	master	+9 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T169242 Develop Page Content Service for Reading Clients
Resolved	None	T177425 Develop General Layer of PCS
Resolved	• Jhernandez	T177426 Develop structured JSON APIs for general consumption
Resolved	• Mholloway	T177431 Develop a Summary JSON API
Duplicate	None	T109698 [EPIC]: Roll out Hovercards to stable on desktop
Declined	None	T109796 [EPIC] Get Hovercards to feature parity with Navigation Pop-ups (tracking) [AOI]
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Duplicate	None	T130671 Hovercards should show for disambiguation pages
Declined	None	T168391 Page previews should display generic preview for disambiguation pages
Resolved	• Nirzar	T168392 Page previews should display custom preview for disambiguation pages
Resolved	ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
Resolved	Jdlrobson	T173952 Remove A/B testing instrumentation code
Duplicate	None	T167433 Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
Duplicate	None	T167429 Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint
Resolved	ovasileva	T165018 Page previews can consume new summary-HTML endpoint
Declined	Jdlrobson	T111329 [GOAL] Page previews on mobileweb
Resolved	Jdlrobson	T164010 [EPIC] Strengthen the APIs we provide in reading web maintained extensions
Resolved	ovasileva	T113094 [EPIC] The Page Summary API needs to provide useful content for the majority of articles
Resolved	Jdlrobson	T171052 Add disambiguation page handling in Page Summary API
Declined	None	T170612 Only fetch content from new Page Summary MCS route when Accept header is v2.0+
Resolved	phuedx	T170667 Security review the Page Summary API in MCS
Declined	None	T171331 Should we add sentence Boundary Detection to the Page Summary API?
Resolved	Jdlrobson	T168848 Bootstrap an initial version of the Page Summary API in MCS
Resolved	Jdlrobson	T172021 It shouldn't be possible for coordinates to be the lead paragraph

Event Timeline

Jdlrobson created this task.Jul 28 2017, 11:27 PM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptJul 28 2017, 11:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson updated the task description. (Show Details)Jul 28 2017, 11:38 PM

• Mholloway subscribed.Jul 31 2017, 6:48 PM

Talked about this in the weekly engineering sync. Rather than piling on more technical debt in MobileFrontend, we'll add an additional API call to get metadata (via pageprops ) and this will help us complete T103362 on long term.

Jdlrobson added a parent task: T168848: Bootstrap an initial version of the Page Summary API in MCS.Jul 31 2017, 6:49 PM

Fix for T152441 will allow us to remove #coordinates and rectify this.

Change 370253 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Scrub #coordinates from response

https://gerrit.wikimedia.org/r/370253

gerritbot added a project: Patch-For-Review.Aug 4 2017, 8:38 PM

Change 370253 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Scrub #coordinates from response

https://gerrit.wikimedia.org/r/370253

Jdlrobson moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 15 2017, 5:14 PM

Jdlrobson edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

Jdlrobson moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Jdlrobson removed a project: Patch-For-Review.

Mentioned in SAL (#wikimedia-operations) [2017-08-15T17:55:00Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@34a1304]: Update mobileapps to 33b80dd (T172829 T152441 T172021 T103362)

Stashbot mentioned this in T103362: Try to get rid of mobileview call for regular pages.Aug 15 2017, 5:55 PM

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 15 2017, 5:56 PM

Mentioned in SAL (#wikimedia-releng) [2017-08-15T17:57:51Z] <bearND> Update mobileapps to 33b80dd (T172829 T152441 T172021 T103362)

Mentioned in SAL (#wikimedia-operations) [2017-08-15T17:59:00Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@34a1304]: Update mobileapps to 33b80dd (T172829 T152441 T172021 T103362) (duration: 04m 00s)

• bearND closed this task as Resolved.Aug 24 2017, 2:27 AM

It shouldn't be possible for coordinates to be the lead paragraphClosed, ResolvedPublicActions