Page MenuHomePhabricator
Create Task
Maniphest T172074

cdnjs mirror not recommending latest version
Closed, ResolvedPublic
Actions

Description

I see that our mirror is recommending outdated versions for "Use latest". https://tools.wmflabs.org/cdnjs/
E.g. Angular-touch is at version 1.6.5 but our mirror says "Use latest (1.5.7)".
The latest version is available at https://tools-static.wmflabs.org/cdnjs/ajax/libs/angular-touch/ but is not being recommended.

@zhuyifei1999 notes that: The relevant code for generating the index is https://github.com/wikimedia/labs-tools-cdnjs-index

(IIUC, it is *not* related to https://github.com/cdnjs/cdnjs#latest-version-url-support and we should actually be linking devs to the latest available version in our UI, as they do at https://cdnjs.com/)

Details

SubjectRepoBranchLines +/-
Handle packages missing a version keylabs/tools/cdnjs-indexmaster+1 -1
Customize query in gerrit

Event Timeline

Quiddity created this task.Jul 30 2017, 7:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2017, 7:35 PM
zhuyifei1999 added a subscriber: yuvipanda.Jul 30 2017, 7:37 PM
yuvipanda unsubscribed.Jul 30 2017, 8:01 PM
bd808 added a project: Tools.Jul 30 2017, 9:07 PM
bd808 subscribed.Jul 30 2017, 9:18 PM

The generator script is blowing up with:

Traceback (most recent call last):
  File "generate.py", line 31, in <module>
    'version': package['version'],
KeyError: 'version'
zhuyifei1999 added a comment.Jul 30 2017, 10:08 PM

Where is cdnjsurl pointing to? I can't seem to reproduce this on https://cdnjs.com/packages.json

gerritbot subscribed.Jul 30 2017, 10:11 PM

Change 368600 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/tools/cdnjs-index@master] Handle packages missing a version key

https://gerrit.wikimedia.org/r/368600

gerritbot added a project: Patch-For-Review.Jul 30 2017, 10:11 PM
gerritbot added a comment.Jul 30 2017, 10:28 PM

Change 368600 merged by BryanDavis:
[labs/tools/cdnjs-index@master] Handle packages missing a version key

https://gerrit.wikimedia.org/r/368600

bd808 claimed this task.Jul 30 2017, 10:37 PM
bd808 triaged this task as Medium priority.
bd808 added a project: cloud-services-team (Kanban).
Restricted Application added a project: User-bd808. · View Herald TranscriptJul 30 2017, 10:37 PM
bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.Jul 30 2017, 10:37 PM
bd808 closed this task as Resolved.Jul 30 2017, 10:45 PM

I fixed the index generation script so that it would deal with the busted https://tools-static.wmflabs.org/cdnjs/ajax/libs/isomorphic-fetch/ package. I also added a cron to the tool account to rebuild the index each day so that it reflects the latest packages that are being mirrored.

bd808 moved this task from Doing to Done on the cloud-services-team (Kanban) board.Jul 31 2017, 6:43 PM
bd808 moved this task from To Do to Done on the User-bd808 board.Jul 15 2020, 9:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL