Page MenuHomePhabricator

Don't fetch results unnecessarily when actions don't warrant it
Closed, ResolvedPublic

Description

We have a few actions that are a no-op in terms of result set. These should not trigger a fetch from the server.

  1. Toggling "Exclude selected" (invert) if there are no selected filters -- does not require a reload of results
  2. Loading a saved query that is already loaded -- does not require a reload of results
    • Caveat: Reloading means refreshing the results. We have other ways to do that (especially with the upcoming live/update results) but we should be aware blocking that will mean users can't reload the query to reload the results.

Details

Related Gerrit Patches:

Event Timeline

Mooeypoo created this task.Jul 31 2017, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2017, 5:41 PM

Change 369571 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Don't reload results for redundant requests

https://gerrit.wikimedia.org/r/369571

Change 369571 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Don't reload results for redundant requests

https://gerrit.wikimedia.org/r/369571

Checked in betalabs for two cases

  • clicking on 'Exclude selected' without making any selection of namespaces - the result set will not be reload
  • if the result set for a saved filter is already displayed, clicking on the name of the same filter in the Saved filters will not reload the page. If there are any new results then "View newest changes" appears.

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.Aug 7 2017, 5:53 PM