Don't fetch results unnecessarily when actions don't warrant it
Closed, ResolvedPublic
Actions

Description

We have a few actions that are a no-op in terms of result set. These should not trigger a fetch from the server.

Toggling "Exclude selected" (invert) if there are no selected filters -- does not require a reload of results
Loading a saved query that is already loaded -- does not require a reload of results
- Caveat: Reloading means refreshing the results. We have other ways to do that (especially with the upcoming live/update results) but we should be aware blocking that will mean users can't reload the query to reload the results.

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Don't reload results for redundant requests	mediawiki/core	master	+22 -3

Customize query in gerrit

Event Timeline

Mooeypoo created this task.Jul 31 2017, 5:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2017, 5:41 PM

Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 31 2017, 7:29 PM

Change 369571 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Don't reload results for redundant requests

https://gerrit.wikimedia.org/r/369571

gerritbot added a project: Patch-For-Review.Aug 1 2017, 11:16 PM

Mooeypoo claimed this task.Aug 1 2017, 11:17 PM

Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 2 2017, 12:31 AM

Change 369571 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Don't reload results for redundant requests

https://gerrit.wikimedia.org/r/369571

ReleaseTaggerBot added a project: MW-1.30-release-notes.Aug 2 2017, 1:00 AM

Checked in betalabs for two cases

clicking on 'Exclude selected' without making any selection of namespaces - the result set will not be reload
if the result set for a saved filter is already displayed, clicking on the name of the same filter in the Saved filters will not reload the page. If there are any new results then "View newest changes" appears.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 7 2017, 4:55 PM

• jmatazzoni closed this task as Resolved.Aug 7 2017, 5:53 PM

Don't fetch results unnecessarily when actions don't warrant itClosed, ResolvedPublicActions

Description

Details

Event Timeline

Don't fetch results unnecessarily when actions don't warrant it
Closed, ResolvedPublic
Actions