Page MenuHomePhabricator

Removal of template parameter inside the reference tag not shown in changes
Closed, InvalidPublic1 Estimated Story Points

Description

Copied from https://www.mediawiki.org/wiki/Topic:Tv6hohgrc48iym9o by 197.218:

Steps to reproduce:

Go to https://en.wikipedia.org/w/index.php?diff=683126701&oldid=679741880&title=Tishma&type=revision&visualdiff&diffmode=visual

Expected:

An annotation on the side bar indicating that "something" within a reference tag changed.

Actual output

No highlighting for changes, with some unrelated text in the visual diff.

Notes:

This is a pretty common case. Someone removed a template parameter "unused_data=@ http://www.bangladesh-pratidin.com" inside a template which is seemingly not supported by the template. The issue is that because that template parameter doesn't seem to alter the page in any way there aren't any visible changes.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana triaged this task as Medium priority.Aug 1 2017, 7:08 PM
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Deskana set the point value for this task to 1.Aug 24 2017, 10:30 AM

I don't think it's because there aren't visible changes on the page - the model of the page has still changed as far as the visual diff is concerned. I'm having trouble reproducing this behaviour locally, so I suspect it is not a visual diff problem.

Ah it's because the reference name="bd-pratidin.com" is defined more than once in the page - so editing anything but the first one won't make a difference.

Sounds like bad wikitext then, close as invalid?