Page MenuHomePhabricator

Ctrl + Tab should not move to next cell in visual table editor and conflicts with switch tab feature in Firefox
Closed, ResolvedPublic1 Story Points

Description

Original source:

https://bugzilla.mozilla.org/show_bug.cgi?id=1385897

Steps to reproduce:

  1. Edit a table cell
  2. Press Ctrl + Tab to switch tabs
  3. Press Ctrl + Tab again to switch back

What happened:

The cursor moved to the next cell.

What should happen:

The cursor should not move because I pressed Ctrl + Tab not not just Tab.

See the attached GIF for an example:

Event Timeline

orschiro created this task.Aug 1 2017, 5:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2017, 5:14 AM
orschiro updated the task description. (Show Details)Aug 1 2017, 5:14 AM
orschiro updated the task description. (Show Details)Aug 1 2017, 5:32 AM

Change 369407 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] LinearTabKeyDownHandler: Abort if modifiers are used

https://gerrit.wikimedia.org/r/369407

Thanks for the patch!

Change 369407 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearTabKeyDownHandler: Abort if modifiers are used

https://gerrit.wikimedia.org/r/369407

Deskana closed this task as Resolved.Aug 1 2017, 7:05 PM
Deskana assigned this task to DLynch.
Deskana triaged this task as Normal priority.
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Deskana set the point value for this task to 1.
Deskana added a subscriber: Deskana.

Talk about fast service!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 1 2017, 7:05 PM

Talk about fast service!

Yeah, super fast! :-D

Very impressive.

Change 369564 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18ae4004f)

https://gerrit.wikimedia.org/r/369564

Change 369564 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18ae4004f)

https://gerrit.wikimedia.org/r/369564