Page MenuHomePhabricator
Create Task
Maniphest T172168

Ctrl + Tab should not move to next cell in visual table editor and conflicts with switch tab feature in Firefox
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Original source:

https://bugzilla.mozilla.org/show_bug.cgi?id=1385897

Steps to reproduce:

  1. Edit a table cell
  2. Press Ctrl + Tab to switch tabs
  3. Press Ctrl + Tab again to switch back

What happened:

The cursor moved to the next cell.

What should happen:

The cursor should not move because I pressed Ctrl + Tab not not just Tab.

See the attached GIF for an example:

Peek 2017-08-01 07-10.gif (533×559 px, 213 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (18ae4004f)mediawiki/extensions/VisualEditormaster+1 -1
LinearTabKeyDownHandler: Abort if modifiers are usedVisualEditor/VisualEditormaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

orschiro created this task.Aug 1 2017, 5:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2017, 5:14 AM
orschiro updated the task description. (Show Details)Aug 1 2017, 5:14 AM
orschiro updated the task description. (Show Details)Aug 1 2017, 5:32 AM
gerritbot subscribed.Aug 1 2017, 3:57 PM

Change 369407 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] LinearTabKeyDownHandler: Abort if modifiers are used

https://gerrit.wikimedia.org/r/369407

gerritbot added a project: Patch-For-Review.Aug 1 2017, 3:57 PM
orschiro added a comment.Aug 1 2017, 4:00 PM

Thanks for the patch!

gerritbot added a comment.Aug 1 2017, 5:32 PM

Change 369407 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearTabKeyDownHandler: Abort if modifiers are used

https://gerrit.wikimedia.org/r/369407

• Deskana closed this task as Resolved.Aug 1 2017, 7:05 PM
• Deskana assigned this task to DLynch.
• Deskana triaged this task as Medium priority.
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• Deskana set the point value for this task to 1.
• Deskana subscribed.

Talk about fast service!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 1 2017, 7:05 PM
orschiro added a comment.Aug 1 2017, 7:39 PM

Talk about fast service!

Yeah, super fast! :-D

Very impressive.

gerritbot added a comment.Aug 1 2017, 10:11 PM

Change 369564 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18ae4004f)

https://gerrit.wikimedia.org/r/369564

gerritbot added a comment.Aug 1 2017, 10:26 PM

Change 369564 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (18ae4004f)

https://gerrit.wikimedia.org/r/369564

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)).Aug 1 2017, 11:00 PM
matmarex mentioned this in T174133: Do not catch Ctrl key combinations on focused language selector on Special:PageLanguage.Sep 11 2017, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits